chore: updated pills text and badge group behaviour #7997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BadgeGroup component to improve external link handling and updates pills text for better clarity. The changes focus on replacing the arrow icon for external links and simplifying badge labels.
- Updated BadgeGroup to show an up-right arrow icon specifically for external links (target="_blank")
- Changed badge text from "Node.js LTS" to "Latest LTS" and "Node.js Current" to "Latest Release"
- Added logic to automatically set target="_blank" for external URLs in withBadgeGroup component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui-components/src/Common/BadgeGroup/index.tsx | Updated icon import and conditional rendering logic for external link indicators |
| apps/site/pages/en/index.mdx | Simplified badge text labels for Node.js releases |
| apps/site/components/withBadgeGroup.tsx | Added automatic external link detection and target="_blank" assignment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7997 +/- ##
==========================================
- Coverage 73.15% 73.13% -0.02%
==========================================
Files 95 95
Lines 8354 8354
Branches 218 218
==========================================
- Hits 6111 6110 -1
- Misses 2242 2243 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
ovflowd
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
github-actions
bot
removed
the
github_actions:pull-request
avivkeller
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small change on our pills for BadgeGroup and the Changelog Badges as discussed on Slack (https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1752848215272629)
Requesting fast-track as this is a small yet convenient change and we cna always iterate if we're unhappy with it cc @nodejs/nodejs-website