Skip to content

feat: pills on footer and clean up code #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2025
Merged

feat: pills on footer and clean up code #7999

merged 2 commits into from
Jul 20, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 20, 2025

This PR removes usage of npm's glob in favor of Node's, as it is stable on Node v22+

This PR moves the release pills to the footer, which is nicer and enables it on all pages.

And all of this is done in this PR for convenience, and lack of time.

@Copilot Copilot AI review requested due to automatic review settings July 20, 2025 13:26
@ovflowd ovflowd requested review from a team as code owners July 20, 2025 13:26
Copy link

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 20, 2025 1:28pm

Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements multiple improvements to the Node.js website: migrating from npm's glob package to Node.js built-in glob functionality, moving release version pills from the homepage to the footer for site-wide availability, and enabling Turbopack for static exports to improve build performance.

  • Replaces npm glob dependency with Node.js native glob from node:fs/promises
  • Moves release version pills (Latest LTS/Latest Release) from homepage to footer component
  • Removes locale-specific homepage files and refactors components for better maintainability

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/ui-components/src/Containers/Footer/index.tsx Adds slots support for injecting content into footer sections
packages/ui-components/src/Common/BadgeGroup/index.tsx Makes as prop optional for better flexibility
packages/ui-components/src/Common/Badge/index.tsx Simplifies component structure and formatting
apps/site/next.helpers.mjs Migrates from npm glob to Node.js native glob API
apps/site/components/withFooter.tsx Integrates release pills into footer using new slots system
apps/site/pages/*/index.mdx Removes locale-specific homepage files
apps/site/types/releases.ts Removes unused releaseAnnounceLink property
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 20, 2025
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.00%. Comparing base (edacebc) to head (49a8d99).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/site/next.helpers.mjs 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7999      +/-   ##
==========================================
- Coverage   73.09%   73.00%   -0.09%     
==========================================
  Files          95       95              
  Lines        8354     8341      -13     
  Branches      219      218       -1     
==========================================
- Hits         6106     6089      -17     
- Misses       2247     2251       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 20, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🔴 66 🔗
/en/about 🟢 100 🟢 97 🟢 100 🔴 58 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 100 🔴 61 🔗
/en/download 🟢 98 🟢 100 🟢 100 🔴 66 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🔴 69 🔗

@ovflowd ovflowd force-pushed the feat/pills-on-footer branch from 49a8d99 to b007442 Compare July 20, 2025 13:40
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 20, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 20, 2025
@ovflowd
Copy link
Member Author

ovflowd commented Jul 20, 2025

cc @nodejs/nodejs-website

@ovflowd
Copy link
Member Author

ovflowd commented Jul 20, 2025

cc @nodejs/nodejs-website I want to fast-track this PR to unblock the development of the partners page. React with a 👍 or 👎

@avivkeller
Copy link
Member

You have my approval.

@ovflowd ovflowd merged commit 3628c11 into main Jul 20, 2025
22 of 28 checks passed
@ovflowd ovflowd deleted the feat/pills-on-footer branch July 20, 2025 14:46
@ovflowd
Copy link
Member Author

ovflowd commented Jul 20, 2025

You have my approval.

Thank you my good sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants