-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: pills on footer and clean up code #7999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements multiple improvements to the Node.js website: migrating from npm's glob
package to Node.js built-in glob functionality, moving release version pills from the homepage to the footer for site-wide availability, and enabling Turbopack for static exports to improve build performance.
- Replaces npm
glob
dependency with Node.js nativeglob
fromnode:fs/promises
- Moves release version pills (Latest LTS/Latest Release) from homepage to footer component
- Removes locale-specific homepage files and refactors components for better maintainability
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/ui-components/src/Containers/Footer/index.tsx |
Adds slots support for injecting content into footer sections |
packages/ui-components/src/Common/BadgeGroup/index.tsx |
Makes as prop optional for better flexibility |
packages/ui-components/src/Common/Badge/index.tsx |
Simplifies component structure and formatting |
apps/site/next.helpers.mjs |
Migrates from npm glob to Node.js native glob API |
apps/site/components/withFooter.tsx |
Integrates release pills into footer using new slots system |
apps/site/pages/*/index.mdx |
Removes locale-specific homepage files |
apps/site/types/releases.ts |
Removes unused releaseAnnounceLink property |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #7999 +/- ##
==========================================
- Coverage 73.09% 73.00% -0.09%
==========================================
Files 95 95
Lines 8354 8341 -13
Branches 219 218 -1
==========================================
- Hits 6106 6089 -17
- Misses 2247 2251 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Lighthouse Results
|
49a8d99
to
b007442
Compare
cc @nodejs/nodejs-website |
cc @nodejs/nodejs-website I want to fast-track this PR to unblock the development of the partners page. React with a 👍 or 👎 |
You have my approval. |
Thank you my good sir! |
This PR removes usage of
npm's
glob
in favor of Node's, as it is stable on Node v22+This PR moves the release pills to the footer, which is nicer and enables it on all pages.
And all of this is done in this PR for convenience, and lack of time.