Fix tests in v5.x for Node 20 #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
KhafraDev
approved these changes
Mar 18, 2025
Signed-off-by: Matteo Collina <[email protected]>
mcollina
force-pushed
the
fix-tests-v5-node-20
branch
from
535bcc9 to
10e028c
Compare
ronag
approved these changes
Mar 18, 2025
metcoder95
approved these changes
Mar 18, 2025
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
mcollina
force-pushed
the
fix-tests-v5-node-20
branch
from
f4587ff to
8d01e58
Compare
Signed-off-by: Matteo Collina <[email protected]>
mcollina
force-pushed
the
fix-tests-v5-node-20
branch
from
8d01e58 to
ae0a79b
Compare
|
@KhafraDev @ronag @metcoder95 this is finally ready. |
KhafraDev
approved these changes
Mar 18, 2025
tsctx
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken tests in v5.x for Node v20.
This PR should not be squashed.