feat(#4230): Implement pingInterval for dispatching PING frames #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
commented
Jun 29, 2025
lib/dispatcher/client-h2.js
Outdated
Comment on lines
173
to
175
| if (err != null) { | ||
| // TODO: should we drop the session? | ||
| client[kOnError](err) |
There was a problem hiding this comment.
Thinkin' twice, I'm over the fence of we should fail rather than actually just emit an event
There was a problem hiding this comment.
I think we should drop the sesson if this error.
mcollina
reviewed
Jul 3, 2025
| * @description Time interval between PING frames dispatch | ||
| * @default 60000 | ||
| */ | ||
| pingInterval?: number; |
mcollina
reviewed
Jul 3, 2025
lib/dispatcher/client-h2.js
Outdated
| session[kHTTP2Session] = null | ||
| session[kHTTP2SessionState] = { | ||
| ping: { | ||
| interval: client[kPingInterval] === 0 ? null : setInterval(onHttp2SendPing, client[kPingInterval], session) |
There was a problem hiding this comment.
Should this interval be unref'ed?
There was a problem hiding this comment.
Good catch; thought I unref'ed, let me adjust it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Closes #4230
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status