feat(rmdir): introduce

[AugustinMauroy]

Related issue

Important

It's use @next codemod CLI

Close #104

TODO

• handle destrucurize imprort
• improve factorization of code

[Copilot]

Pull Request Overview

This PR introduces a new codemod recipe that migrates deprecated fs.rmdir calls with recursive: true to the new fs.rm API (including Sync and Promise variants) while adding appropriate tests and configuration.

• Adds a workflow definition, TypeScript config, and package manifest for the rmdir recipe
• Implements and documents the transform in src/workflow.ts
• Includes input/expected tests and updates biome.jsonc to ignore test fixtures

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
recipes/rmdir/workflow.yml	Workflow node for AST transform (step description needs update)
recipes/rmdir/tsconfig.json	TypeScript compiler options for the recipe
recipes/rmdir/tests/input/file.js	Test inputs covering rmdir with and without recursive
recipes/rmdir/tests/expected/file.js	Expected outputs transforming to rm
recipes/rmdir/src/workflow.ts	Transform implementation for fs.rmdir -> fs.rm
recipes/rmdir/package.json	Recipe metadata and dependencies
recipes/rmdir/codemod.yml	Codemod descriptor (name and workflow reference need fixes)
recipes/rmdir/README.md	Documentation and examples for the recipe
biome.jsonc	Updated ignore patterns for input and expected dirs

Comments suppressed due to low confidence (3)

recipes/rmdir/workflow.yml:9

• The step description references an unrelated assert import transform. Update it to describe the fs.rmdir → fs.rm migration (e.g., "Convert deprecated fs.rmdir recursive calls to fs.rm with force").

      - name: "Replace `assert` import attribute to the `with` ECMAScript import attribute."

recipes/rmdir/codemod.yml:2

• The codemod name is inconsistent with this recipe. Rename it to something like nodejs/rmdir-to-rm to reflect the actual transformation.

name: "nodejs/import-assertions-to-attributes"

recipes/rmdir/codemod.yml:7

• The workflow file is named workflow.yml but this references workflow.yaml. Update the filename reference to match (workflow.yml) so the codemod can find and run the workflow.

workflow: "workflow.yaml"

[Copilot]

This replacement drops any additional user-specified options besides recursive. Consider merging existing properties from the original options object with { force: true } instead of overwriting them.

Suggested change

	newCallText = `fs.rm(${path}, { recursive: true, force: true }, ${callback})`;
	} else {
	// No callback
	const path = call.getMatch("PATH")?.text();
	newCallText = `fs.rm(${path}, { recursive: true, force: true })`;
	}
	} else if (callText.includes("fs.rmdirSync(")) {
	// Handle fs.rmdirSync -> fs.rmSync
	const path = call.getMatch("PATH")?.text();
	newCallText = `fs.rmSync(${path}, { recursive: true, force: true })`;
	} else if (callText.includes("fs.promises.rmdir(")) {
	// Handle fs.promises.rmdir -> fs.promises.rm
	const path = call.getMatch("PATH")?.text();
	newCallText = `fs.promises.rm(${path}, { recursive: true, force: true })`;
	newCallText = `fs.rm(${path}, { ...${optionsText}, force: true }, ${callback})`;
	} else {
	// No callback
	const path = call.getMatch("PATH")?.text();
	newCallText = `fs.rm(${path}, { ...${optionsText}, force: true })`;
	}
	} else if (callText.includes("fs.rmdirSync(")) {
	// Handle fs.rmdirSync -> fs.rmSync
	const path = call.getMatch("PATH")?.text();
	newCallText = `fs.rmSync(${path}, { ...${optionsText}, force: true })`;
	} else if (callText.includes("fs.promises.rmdir(")) {
	// Handle fs.promises.rmdir -> fs.promises.rm
	const path = call.getMatch("PATH")?.text();
	newCallText = `fs.promises.rm(${path}, { ...${optionsText}, force: true })`;

[avivkeller]

What about all the other options?

[AugustinMauroy]

idk if there are an impact on the codemod

[avivkeller]

I don't love all the if...then with repeated logic, can we optimize and refactor a bit?

[AugustinMauroy]

I should use one AST-grep query + update by function call

[AugustinMauroy]

i had push shitty commit because to move forward I need new utility