feat(import-assertions-to-attributes): introduce
#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustinMauroy
force-pushed
the
import-attribute
branch
from
bf3be6a to
7e1fc0a
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a codemod to update import assertions by replacing the legacy "assert" attribute with the new "with" syntax, while also adding tests and updating project configuration files.
- Implements transformation logic for both static and dynamic imports in src/workflow.ts
- Adds tests and snapshots in various formats (mjs, js, cjs, and edge cases) to verify the codemod’s changes
- Updates configuration files (tsconfig.json, package.json, .codemodrc.json, biome.jsonc) to support the new codemod
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes/import-assertions-to-attributes/tsconfig.json | Adds configuration for TypeScript compilation |
| recipes/import-assertions-to-attributes/tests/workflow.test.ts | Introduces tests to run the codemod functionality |
| recipes/import-assertions-to-attributes/tests/workflow.test.snap.cjs | Provides snapshot tests for expected codemod outcomes |
| recipes/import-assertions-to-attributes/tests/fixtures/* | Contains sample files using both old and new import syntaxes |
| recipes/import-assertions-to-attributes/tests/expected/* | Provides expected file outputs after codemod transformation |
| recipes/import-assertions-to-attributes/src/workflow.ts | Implements the codemod logic to replace "assert" with "with" |
| recipes/import-assertions-to-attributes/package.json | Defines package metadata and scripts for testing and running the codemod |
| recipes/import-assertions-to-attributes/.codemodrc.json | Configures codemod runtime settings |
| biome.jsonc | Updates ignore settings to exclude test fixtures and expected files |
avivkeller
reviewed
Jun 24, 2025
AugustinMauroy
changed the title
import-attributes): introduce import-attributes): introduce
|
cc @alexbit-codemod What I have produced is still different from what CodeMod studio offers. Could you give me some feedback on the best approach? |
avivkeller
reviewed
Jun 26, 2025
AugustinMauroy
force-pushed
the
import-attribute
branch
2 times, most recently
from
ff1f364 to
90c99de
Compare
AugustinMauroy
changed the title
import-attributes): introduce import-assertions-to-attributes): introduce
JakobJingleheimer
approved these changes
Jul 2, 2025
Comment on lines
+27
to
+28
| importNode.children().map(child => { | ||
| if (child.kind() === 'assert' && child.text() === 'assert') { |
There was a problem hiding this comment.
Nit: I expected this can be handled above in the ast grep, but it may well be a case of "6 of one, ½ a dozen of the other".
There was a problem hiding this comment.
for strange reason if you use kind: 'assert' in query it's throw an error
AugustinMauroy
force-pushed
the
import-attribute
branch
from
3c29f7c to
9c685b1
Compare
This was referenced Jul 3, 2025
avivkeller
approved these changes
Jul 17, 2025
AugustinMauroy
force-pushed
the
import-attribute
branch
3 times, most recently
from
540dc7f to
d3b3fc3
Compare
AugustinMauroy
force-pushed
the
import-attribute
branch
from
c6d01a0 to
eb51daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description