-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add first implementation of collector of sharedmobility #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add first implementation of collector of sharedmobility #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main points are using the newer SDK (s3-poller as reference) and removing the helm config files. We will add the specific helm file ourselves
The rest are minor issues with dead/obsolete code and files.
collectors/sharedmobility/infrastructure/helm/echarging-driwe.yaml
Outdated
Show resolved
Hide resolved
collectors/sharedmobility/infrastructure/helm/echarging-driwe.yaml
Outdated
Show resolved
Hide resolved
collectors/sharedmobility/infrastructure/helm/echarging-route220.yaml
Outdated
Show resolved
Hide resolved
collectors/sharedmobility/infrastructure/helm/matomo-noi-transparency.yaml
Outdated
Show resolved
Hide resolved
Hi @clezag I’ve addressed all your points and pushed the transformer directory as well. However, I'm encountering two errors when I test the transformer:
Let me know if you have any suggestions or if there's anything specific you'd like me to adjust. Thanks! |
@Giacomo92 Looks good to me in general. ErrorsBased on the .env.example you committed (I assume your .env was the same), the writer API URL is wrong. The correct testing environment URL would be https://mobility.share.opendatahub.testingmachine.eu, but you should not use that during development anyway, as you don't have any valid credentials. Instead, spin up the timeseries specific services locally alongside the ingestion core, as documented here. For the rabbitmq issue: In general, we intend the boilerplate default setup to work with the infrastructure compose files out of the box. If they don't, please let us know and we will fix it. If you have further issues running the local dev setup, feel free to reach out to me directly. CollectorLooks good! Just out of curiosity: Did you test collecting the full dataset (all pages)? There should be a size limit of 16MB in the raw data table, I assumed we would run into it if the raw data is merged into a single JSON. Transformer
|
No description provided.