Add nvim_oxi::string! macro that produces nvim_oxi::Strings
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noib3
requested changes
Oct 1, 2024
|
@noib3 I've pushed the changes, let me if anything else needs to be updated. |
|
Hi, sorry for the long delay. If you still want to finish the PR, I'd merge it after this is addressed and all the commits are squashed. |
types: rename `size` field to `len` in `String` types: remove `#[repr(C)]` from `StringBuilder` types: use the `String` type itself instead of redefining the fields in `StringBuilder` types: a less conservative reallocation for `StringBuilder` types: update comment on deallocation in `StringBuilder` types(string): keep the size of allocation in string to a power of 2.
SCJangra
force-pushed
the
string-macro
branch
from
803e1ff to
9197625
Compare
No problem
Done |
noib3
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184