Code

Cleanup StringBuilder methods#211

Code

Merged

noib3 merged 36 commits intonoib3:mainnoib3/nvim-oxi:mainfrom airblast-dev:string_cleanupairblast-dev/nvim-oxi:string_cleanupCopy head branch name to clipboardJan 2, 2025

+225-52

Commits

Commits on Dec 30, 2024

• implement StringBuilder::reserve, StringBuilder::reserve_exact StringBuilder::with_capacity

  airblast-dev

  committed
  4d555fb

  Copy full SHA for 4d555fb

• cleanup StringBuilder

  Show description for 747e377
  airblast-dev

  committed
  747e377

  Copy full SHA for 747e377

• use StringBuilder::reserve_exact in String::from_bytes

  Show description for 259a22a
  airblast-dev

  committed
  259a22a

  Copy full SHA for 259a22a

• reuse StringBuilder::reserve_exact in StringBuilder::reserve

  airblast-dev

  committed
  5aebd6d

  Copy full SHA for 5aebd6d

• add comment for StringBuilder::push_bytes

  airblast-dev

  committed
  62ea409

  Copy full SHA for 62ea409

• Merge branch 'main' into string_cleanup

  airblast-dev

  committed
  33561c0

  Copy full SHA for 33561c0

• avoid allocating for 0 capacity in StringBuilder::reserve*

  airblast-dev

  committed
  beca9ba

  Copy full SHA for beca9ba

• dont allocate for an extra byte in StringBuilder::push_bytes

  Show description for 23f858d
  airblast-dev

  committed
  23f858d

  Copy full SHA for 23f858d

Commits on Dec 31, 2024

• fix allocation sizes for StringBuilder

  Show description for 9350887
  airblast-dev

  committed
  9350887

  Copy full SHA for 9350887

• add tests

  airblast-dev

  committed
  8b6f8c8

  Copy full SHA for 8b6f8c8

• remove _ casts to avoid type changes with refactors

  airblast-dev

  committed
  90744eb

  Copy full SHA for 90744eb

• shrink allocation to decrease leak size

  Show description for c3b7ebb
  airblast-dev

  committed
  c3b7ebb

  Copy full SHA for c3b7ebb

• cleanup tests

  airblast-dev

  committed
  b8fac4c

  Copy full SHA for b8fac4c

• optimize String::from_bytes

  Show description for 7488494
  airblast-dev

  committed
  7488494

  Copy full SHA for 7488494

• add extra checks for debug mode

  airblast-dev

  committed
  38ad425

  Copy full SHA for 38ad425

• add doc comment

  airblast-dev

  committed
  3df32f5

  Copy full SHA for 3df32f5

• remove redundant comment

  airblast-dev

  committed
  2c507a6

  Copy full SHA for 2c507a6

• use malloc in String::with_capacity

  Show description for ebc1b81
  airblast-dev

  committed
  ebc1b81

  Copy full SHA for ebc1b81

• add test for StringBuilder::with_capacity

  airblast-dev

  committed
  7addd67

  Copy full SHA for 7addd67

Commits on Jan 1, 2025

• drop empty strings with reserved capacity

  airblast-dev

  committed
  33a6b5a

  Copy full SHA for 33a6b5a

• fix off by one in alloc check

  Show description for 5d61731
  airblast-dev

  committed
  5d61731

  Copy full SHA for 5d61731

• use with_capacity instead of reserve_exact

  airblast-dev

  committed
  47b19a2

  Copy full SHA for 47b19a2

• remove finish_unchecked

  airblast-dev

  committed
  291934a

  Copy full SHA for 291934a

• remove duplicate code in reserve*

  airblast-dev

  committed
  4f84eac

  Copy full SHA for 4f84eac

• reword remaining capacity docs

  airblast-dev

  committed
  15a3b96

  Copy full SHA for 15a3b96

• remove extra check

  airblast-dev

  committed
  6f54bc5

  Copy full SHA for 6f54bc5

• fix typo

  airblast-dev

  committed
  81d561c

  Copy full SHA for 81d561c

Commits on Jan 2, 2025

• remove redundant comment

  airblast-dev

  committed
  2972fa7

  Copy full SHA for 2972fa7

• remove capacity check

  airblast-dev

  committed
  df371ab

  Copy full SHA for df371ab

• fmt

  airblast-dev

  committed
  6f6a6cd

  Copy full SHA for 6f6a6cd

• add null check in finish

  airblast-dev

  committed
  c816c7d

  Copy full SHA for c816c7d

• make finish public

  airblast-dev

  committed
  2304160

  Copy full SHA for 2304160

• fmt

  Show description for 8d464dc
  airblast-dev

  committed
  8d464dc

  Copy full SHA for 8d464dc

• Format comments

  Show description for a101287
  noib3

  committed
  a101287

  Copy full SHA for a101287

• Re-add commented out capacity check

  noib3

  committed
  f7b29d3

  Copy full SHA for f7b29d3

• Rename reserve_raw to realloc

  noib3

  committed
  cb67a1c

  Copy full SHA for cb67a1c