Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor buffer storage 3 #178

Open
wants to merge 2 commits into
base: 12-17-refactor_buffer_storage_split
Choose a base branch
from

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Dec 18, 2024

Important

Add wait_for_zoom_attachment() to handle race condition with zoom state in rendering process.

  • Behavior:
    • Add wait_for_zoom_attachment() in Renderer to handle race condition with zoom state.
    • Use wait_for_zoom_attachment() in ReglRenderer in regl_rendering.ts to ensure zoom state is set before rendering.
  • Types:
    • Update onZoomCallback type in types.ts to use ZoomTransform directly.
  • Imports:
    • Add Selection import from d3-selection in rendering.ts.

This description was created by Ellipsis for 01d31db. It will automatically update as commits are pushed.

Copy link
Collaborator Author

bmschmidt commented Dec 18, 2024

@bmschmidt bmschmidt marked this pull request as ready for review January 16, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant