Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix msvc compilation on windows with vulkan #1434

Merged
merged 1 commit into from
Sep 16, 2023
Merged

fix msvc compilation on windows with vulkan #1434

merged 1 commit into from
Sep 16, 2023

Conversation

jacoobes
Copy link
Collaborator

@jacoobes jacoobes commented Sep 16, 2023 •
edited
Loading

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

@jacoobes
Update llama.cpp.cmake
aa652c5 
Signed-off-by: Jacob Nguyen <[email protected]>
@jacoobes jacoobes changed the title Update llama.cpp.cmake fix msvc compilation on windows with vulkan Sep 16, 2023
@jacoobes jacoobes marked this pull request as ready for review September 16, 2023 18:31
@manyoso manyoso requested review from manyoso and apage43 and removed request for manyoso September 16, 2023 18:31
apage43
apage43 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@apage43 apage43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed typescript build script (msbuild/"Visual Studio" generator) now works, qt gui build (ninja) still works, and mingw build (for python bindings) still works

@apage43 apage43 merged commit e86c637 into main Sep 16, 2023
@cebtenzzre cebtenzzre deleted the fixvulkanwinmsvc branch February 10, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apage43 apage43 apage43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacoobes @apage43