Remove binary state from high-level API and use Jinja templates #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
force-pushed
the
remove-binarystate
branch
from
5cc501c
to
6400a7e
Compare
manyoso
force-pushed
the
remove-binarystate
branch
from
19e772f
to
5c3d83d
Compare
- Python bindings use `jinja2` - server.cpp is not implemented - chatapi.cpp is not implemented Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
This reverts commit 15e8fba.
Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre
force-pushed
the
remove-binarystate
branch
from
2be19f2
to
d2b6ba3
Compare
We still need this for models that don't include bos_token in their chat template. Llama 3.1 8B Instruct sets this to false. Signed-off-by: Jared Van Bortel <[email protected]>
Importantly, the non-chat completions endpoint (`/v1/completions`) no longer uses a system prompt or LocalDocs, as those are not applicable. Signed-off-by: Jared Van Bortel <[email protected]>
Before this PR, GPT4All inserted a system message into non-chat completions, and it attempted to use LocalDocs with them. It no longer does either of these things because they do not make sense here. This changes the output slightly, so the test needs to be updated. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the top commit, "WIP". Everything else is #3073.