Add Proxy and SSL Config Options to Python SDK #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cgivre <[email protected]>
Signed-off-by: cgivre <[email protected]>
cgivre
force-pushed
the
add-requests-options
branch
from
5b2481b to
a00b012
Compare
cgivre
changed the title
|
@cebtenzzre Any chance we could get this reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds two configuration options:
proxiesandverify_sslto the constructor and any methods which makeGETrequests using therequests.get()method. I added default values so that the existing behavior should remain the same.Issue ticket number and link
Issue 3068
#3068
Checklist before requesting a review
Notes
This PR allows users to use the SDK in corporate environments.