Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatView: make "stop" and "copy conversation" work again #3336

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Dec 20, 2024

…gression

in a few places in QML that were using this method. This PR fixes two of these issues:

It also adds a fixme in the code for a third issue which is less of a priority:

…gression

in a few places in QML that were using this method. This PR fixes two of
these issues:

* Issue #3333 - the stop generation button no longer working
* Issue #3335 - the copy entire conversation button no longer working

It also adds a fixme in the code for a third issue which is less of a priority:

* Issue #3334 - not sending the conversation to the datalake.

Signed-off-by: Adam Treat <[email protected]>
@manyoso manyoso requested a review from cebtenzzre December 20, 2024 11:55
@manyoso
Copy link
Collaborator Author

manyoso commented Dec 20, 2024

This doesn't add the <stopped> tag back which maybe it should? It also doesn't label the prompt and the responses so the copied conversation isn't so readable... maybe should add this even though it would be a behavior change?

In order to add the <stopped> back to it this would need to be a permanent field of ChatItem and serialized as such as the way it was being done before in Javascript would not preserve it across loads.

UPDATE: I tested and found that the <stopped> tag hasn't been working even as far back as 3.0.0 so it isn't germane to this change.

@manyoso manyoso marked this pull request as draft December 20, 2024 11:58
@manyoso
Copy link
Collaborator Author

manyoso commented Dec 20, 2024

Okay, comparing to the copy conversation in v3.5.3 it is clear this PR still needs work.... fixing.

@manyoso manyoso marked this pull request as ready for review December 20, 2024 12:55
gpt4all-chat/qml/ChatView.qml Show resolved Hide resolved
@cebtenzzre
Copy link
Member

Also, should add a changelog entry.

@cebtenzzre cebtenzzre changed the title The ChatModel::get method was removed which unfortunately caused a re… ChatView: make "stop" and "copy conversation" work again Dec 20, 2024
Signed-off-by: Adam Treat <[email protected]>
@manyoso manyoso merged commit 13e694e into main Dec 20, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants