Fix index used by LocalDocs when tool calling/thinking is active #3451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
ThatTechedGuy
approved these changes
Feb 3, 2025
manyoso
approved these changes
Feb 3, 2025
cgivre
pushed a commit
to cgivre/gpt4all
that referenced
this pull request
Feb 4, 2025
…ic-ai#3451) Signed-off-by: Jared Van Bortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3445
When using tool calling or reasoning (e.g. DeepSeek) and LocalDocs, the second response would be an error like this:
Which is accurate—the item at (global) index 3 is the about-to-be-generated response, not a prompt.
This was caused by using the index in the flattened list instead of the index of the parent ChatItem in its container. The cleanest solution is to just store the index of the original ChatItem parent in the MessageItem, so we don't have to try and look it up later. This simplifies the query prompt lookup, removing the
startOffsetaddition (since the index is now saved before we slice the list for the local server).I have tested and confirmed that it now uses the expected peer index of 2.