-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add replacement jinjas for OLMoE and granite-3.1 #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8b-instruct Added jinja replacement templates for - https://huggingface.co/ibm-granite/granite-3.1-8b-instruct - https://huggingface.co/allenai/OLMoE-1B-7B-0924-Instruct Differences to original templates (but doesn't prevent a merge!): - [ ] ``\nToday's Date: \" + strftime_now('%B %d, %Y') + \".` as encountered in granite-3.1-8b-instruct's original tokenizer_config.json. Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: ThiloteE <[email protected]>
This is the out of the box (original) template in GPT4All for ibm-granite/granite-3.1-3b-a800m-instruct:
@cebtenzzre maybe you can run it through your script. I am at a loss what exactly breaks the syntax. When I edit the file locally in QT and run, it gets replaced correctly, but when pulling from this branch, it doesn't, so something is off and I don't know what exactly. |
Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: ThiloteE <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
ThiloteE
commented
Feb 12, 2025
5 tasks
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added jinja replacement templates for
Notes
Differences to original templates (but doesn't prevent a merge!):
\nToday's Date: \" + strftime_now('%B %d, %Y') + \".
as encountered in granite-3.1-8b-instruct's original tokenizer_config.json.Issue ticket number and link
Resolves #3053.
Contributes to #3159.
Checklist before requesting a review