Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVX512 #21

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Add support for AVX512 #21

merged 2 commits into from
Jan 29, 2024

Conversation

iver56
Copy link
Collaborator

@iver56 iver56 commented Jan 29, 2024

This seems to make it ~14% faster on a Intel i7 11700K with AVX-512.

It runs with the same exec time as before on an older Intel CPU without AVX-512.

I haven't made an AVX512-equivalent of minmax_avx_strided yet

#2

@iver56 iver56 requested a review from magnus-nomono January 29, 2024 09:36
Copy link
Contributor

@magnus-nomono magnus-nomono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little speed up on modern machines there. One small change request for you to consider, but overall approved

numpy_minmax/_minmax.c Outdated Show resolved Hide resolved
Co-authored-by: magnus-nomono <[email protected]>
@iver56 iver56 merged commit 6b7e753 into main Jan 29, 2024
@iver56 iver56 deleted the ij/avx512 branch January 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants