Skip to content

Feat: provide safety net for block updates by walking up the entry chain#2

Merged
arontseggai merged 2 commits intonoprotocol:release/craft5-with-akamai-driver-supportfrom
nondescriptpointer:release/craft5-with-akamai-driver-support
Mar 19, 2026
Merged

Feat: provide safety net for block updates by walking up the entry chain#2
arontseggai merged 2 commits intonoprotocol:release/craft5-with-akamai-driver-supportfrom
nondescriptpointer:release/craft5-with-akamai-driver-support

Conversation

@nondescriptpointer
Copy link

Walk up the entry ownership chain to always purge the root entry.

Handles following cases:

  • Block updates without saves to the parent
  • Parent save is skipped due to isDraftOrRevision or resaving guards
  • New blocks that are added

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “safety net” purge behavior intended to ensure cache tags for the root owning entry are purged when nested content changes don’t result in a parent save, by walking up an ownership chain.

Changes:

  • Walk up an element ownership chain and enqueue purge tags for the root owner’s section and element ID.
  • Add a max-depth guard to prevent infinite traversal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@arontseggai
Copy link

@nondescriptpointer ik heb copilot de review laten doen.

Kan je de uitkomst verwerken?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@arontseggai
Copy link

Tested on staging.

Purging still works and works on the scenario's written on the ticket.

I will merge this.

@arontseggai arontseggai merged commit b605537 into noprotocol:release/craft5-with-akamai-driver-support Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants