Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for some format variants #12

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

noritada
Copy link
Owner

This PR adds support for some format variants.

Some of the systems that generate data in the WNI RU format generate data in variant formats,
which are slightly different from the format specified in the specifications referenced in the development of this library.
This PR adds support for following 3 cases:

  • Allow a trailing comma in the schema description
  • Allow an empty field name in the schema description when it is the only field in the schema
  • Allow use of <N>STR instead of <N>NSTR in the schema description

Each of these cases can be optionally enabled using flags.

All of these options are enabled in the CLI and the web demo app.

Copy link
Owner Author

@noritada noritada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed. Passing CI.

@noritada noritada merged commit 0f70b87 into master Oct 22, 2024
3 checks passed
@noritada noritada deleted the feat/support-for-format-variants branch October 22, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant