Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palni palci theming #1

Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open

Palni palci theming #1

wants to merge 97 commits into from

Conversation

kellyChex
Copy link

Fixes #issuenumber ; refs #issuenumber

Present tense short summary (50 characters or less)

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

class PostsController
  def index
    respond_with Post.limit(10)
  end
end

Changes proposed in this pull request:
*
*
*

@samvera/hyrax-code-reviewers

dlpierce and others added 30 commits August 30, 2017 11:36
Handle potential NilClass
No longer run S3 related specs on non-samvera-labs repos. This will allow specs to pass on forks.
improved isbn_regex which was catching series of 9 digits occasionally found in DOIs
…earch-results-with-hyrax

1344 align search results with hyrax
Modified isbn regex
Working solution

Refactor

Tests
Restore log methods, increase rubocop ClassLength
orangewolf and others added 30 commits December 3, 2018 21:38
Support pinging fedora endpoints with basic auth
* Update nokogiri to 1.10.1

This fixes CVE-2018-14404

* upgrade mods (required after nokogiri update)
Remove IIIF code from Hyku, rely on Hyrax functionality
Remove labs from several badge links to reflect new repo home
update bootstrap sass to fix vulnerability
… nil issue, implement color options, allow custom styles for themes, add font choices, rename color params to customization params, Use Hyrax::UploadedFileUploader vs BannerImageUploader, custom placeholder images, default work image, make the logo height capped by default
…side Docker

This commit is in preperation of beginning to release docker images that can be used via Docker Hub with each new release. It also allows for fully dockerized development environment and production environments.

Two phase Docker build - base and main. The goal here are much faster build times by moving seldom changing items to the base image.

Moves to Passenger base image which allows a few real niceties:

  - for dev, you can restart the web process w/o restarting the container, saving a lot of time
  - for prod passenger is more effecient by default in a variety of configurations than puma. Puma frequenty requires more tuning
  - means nginx is serving assets, so no extra proxy is required

Note, this makes the build a little bigger, but with libreoffice and fits in there this change is a pretty small fraction in my opinion.

Uses a nulldb to compile assets during build, making deployment much faster. Also set up to allow for optional assets volume, which makes keeping cached assets possible

This Dockerfile moves fits to always be in the same place in the container. There is still a version file present, so we don't really need it in the path and that means we don't have to update multiple places when we change versions. Just
 in the Dockerfile.base

Sets the admin and default host in dockerfile and virtual_host attributes. That allows this setup to work in dev by default with common proxies like Dory and others.

Makes test adjustments to allow for Docker environment, adds an external Chrome driver docker container to the dev environment

Splits the production and dev docker-compose.yml files. Reduced dev zookeeper to 1, removed lb and memcached from dev. Splitting futher refinement of production docker-compose in to a seperate task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants