Avoid using global logger

[catap]

Somehow it fixes mitmproxy/mitmproxy#7680

[notypecheck]

Thanks a lot, I will merge and make a release in a couple of days.

[mhils]

FWIW a very common pattern here is to have

logger = logging.getLogger(__name__)

at the beginning of the file and then use logger in the rest of the file. :)

[catap]

The only things I don't understand, yet is why this line:

    # register handler
    _handlers[name] = handler
    logging.debug("registered %r handler: %r", name, handler)

brokes mitmproxy, and rewrite it into:

    logging.getLogger(__name__).debug("registered %r handler: %r", name, handler)

or

    logging.getLogger().debug("registered %r handler: %r", name, handler)

doesn't broke it.

[catap]

Aha!

The call logging.debug (or similar one) make implicit configuration of the logger, as documented here: https://docs.python.org/3/library/logging.html#logging.debug and it dismiss the second configuration from user application.

[catap]

FWIW a very common pattern here is to have

logger = logging.getLogger(__name__)

at the beginning of the file and then use logger in the rest of the file. :)

The commit in question had removed it :)

650121d#diff-fb2e5a842fd78374e92b5bd2034fcfd0a8a1b25488f23c906abcd4326d2ae410

[mhils]

https://docs.python.org/3/library/logging.html and https://docs.python.org/3/howto/logging.html both recommend logging.getLogger(__name__), so I think it'd worth to reconsider that approach when using the logging module. :)

[notypecheck]

I wasn't aware that logging.debug could cause side effects 👀, I'll just introduce a global logger how other libraries usually do that.

[catap]

@ThirVondukr now it should pass lint