Fix Pack to respect NoBuild property for reference assemblies#307
Draft
Fix Pack to respect NoBuild property for reference assemblies#307
Conversation
Co-authored-by: clairernovotny <[email protected]>
Co-authored-by: clairernovotny <[email protected]>
Copilot
AI
changed the title
[WIP] Fix pack command to respect nobuild setting
Fix Pack to respect NoBuild property for reference assemblies
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msbuild /t:pack /p:NoBuild=trueignores the NoBuild flag when reference assemblies are used, causing unwanted rebuilds that overwrite signed DLLs.Root Cause
The
_SdkGetReferenceAssembliestarget unconditionally depends onBuild, forcing reference assembly projects to rebuild during pack operations regardless of the NoBuild property.Changes
Modified
Source/MSBuild.Sdk.Extras/Build/ReferenceAssembly.targets:Introduced
_SdkGetReferenceAssembliesWithBuildas a conditional build gate:Updated
_SdkGetReferenceAssembliesto depend on the conditional target instead ofBuilddirectlyModified
_ExtrasGetRefsForPackageto propagateNoBuild=$(NoBuild)to reference assembly project invocationsWhen NoBuild is true, the target executes but skips the Build dependency, using existing outputs from disk.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.