Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Biome to lint and format files #77

Merged
merged 9 commits into from
Mar 11, 2024
Merged

Conversation

citrus327
Copy link
Collaborator

This PR includes the following:

  1. Remove eslint, prettier and other redundunt dependencies.
  2. add biome for linter and formatter
  3. fix fixable issues warned by biome
  4. integrate biome for vscode and add it as recommendation extension

Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: e0c0c41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 69.08213% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 70.64%. Comparing base (4e64dc1) to head (e0c0c41).

Files Patch % Lines
packages/minecat/src/cmd/install.ts 0.00% 37 Missing ⚠️
packages/minecat/src/cmd/add-ext.ts 75.00% 10 Missing ⚠️
packages/minecat/src/cmd/run.ts 16.66% 5 Missing ⚠️
packages/minecat/src/cmd/add.ts 0.00% 4 Missing ⚠️
packages/minecat/postinstall.js 0.00% 3 Missing ⚠️
packages/libargs/src/run.ts 92.30% 2 Missing ⚠️
packages/libargs/src/util.ts 87.50% 1 Missing ⚠️
packages/minecat/src/cmd/init.ts 96.15% 1 Missing ⚠️
packages/minecat/src/types/package-json.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
- Coverage   70.78%   70.64%   -0.15%     
==========================================
  Files          22       22              
  Lines        1270     1250      -20     
  Branches      109      108       -1     
==========================================
- Hits          899      883      -16     
+ Misses        371      367       -4     
Flag Coverage Δ
libargs 83.33% <94.11%> (-0.88%) ⬇️
minecat 66.63% <60.89%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@npmstudy npmstudy merged commit bb21a93 into npmstudy:dev Mar 11, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants