Update nrfxlib to 2.9.1 #11
Conversation
|
Looks good. Please also update the version in the readme and add this version to the changelog (also in the readme) |
|
Thank you for your review! Updated. I guessed tag names ... but there are some tags missing of the earlier verions. Maybe it's worth to tag the corresponding commits? |
|
Wow you're fast! Thanks :) |
|
Ha, well I switched to this tab right as you pushed, so saw it immediately. I'll cut a new release. You're right about the tags, seems like we didn't keep them up... |
|
Hmmm, trying to build it... |
|
Ah ok, never mind. A submodule reinit seems to have done the job |
|
Ugh, wait no. Cargo build doesn't show that error, but cargo publish does... |
|
Found it! |
|
Ah sry ... wasn't aware of that. cargo build worked flawlessly on my machine. I guess it's a |
|
Don't worry, not the first time this happened. I also always forget.
I guess this should be put in CI too, but oh well. I guess the publish command actually looks at what is included in the crate
…________________________________
From: Juergen Fitschen ***@***.***>
Sent: Monday, March 24, 2025 1:15:56 PM
To: nrf-rs/nrfxlib-sys ***@***.***>
Cc: Dion Dokter ***@***.***>; State change ***@***.***>
Subject: Re: [nrf-rs/nrfxlib-sys] Update nrfxlib to 2.9.1 (PR #11)
Ah sry ... wasn't aware of that. cargo build worked flawlessly on my machine. I guess it's a cargo publish-only problem?
—
Reply to this email directly, view it on GitHub<#11 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACBGGZ5UFM7K7TMPBOJERBD2V7ZPZAVCNFSM6AAAAABZQJQQ7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBXHEZDSNRZHA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
[jue89]jue89 left a comment (nrf-rs/nrfxlib-sys#11)<#11 (comment)>
Ah sry ... wasn't aware of that. cargo build worked flawlessly on my machine. I guess it's a cargo publish-only problem?
—
Reply to this email directly, view it on GitHub<#11 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACBGGZ5UFM7K7TMPBOJERBD2V7ZPZAVCNFSM6AAAAABZQJQQ7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBXHEZDSNRZHA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Released! |
I've used this branch to test the change:
https://github.com/jue89/nrf-modem/tree/bump-nrfxlib-sys
I also added a
logfeature to include Nordic's binary with logging enabled.