modules: storage: Add batch session timeout #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a batch session timeout mechanism to the storage module to prevent scenarios where a module opens a batch session but never closes it, which would block other sessions and prevent data storage. The implementation includes a configurable timeout that automatically closes inactive sessions and enables data storage to continue while a session is active.
Key changes:
- Added configurable batch session timeout with a default of 60 seconds
- Implemented automatic session closure when timeout expires
- Modified buffer state to allow data storage during active batch sessions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| app/src/modules/storage/storage.c | Core timeout implementation with work queue handler, state machine updates, and data handling during active sessions |
| app/src/modules/storage/Kconfig.storage | Added configuration option for session timeout duration |
| tests/module/storage/CMakeLists.txt | Added test configuration for the new timeout setting |
| tests/module/storage/src/storage_module_test.c | Added comprehensive tests for timeout behavior and concurrent data storage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add batch session timeout to address the scenario where a module opens a batch session and never closes it. During this, no data was stored and no session could be opened. At the same time, allow data storage while session is active. Signed-off-by: Jan Tore Guggedal <[email protected]>
jtguggedal
force-pushed
the
storage-timeout
branch
from
f5c411a to
d7e143f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add batch session timeout to address the scenario where a module opens a batch session and never closes it.
During this, no data was stored and no session could be opened. At the same time, allow data storage while session is active.