Zephyr: add new ISO hosts in GAP #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following tests added in PTS with ICS Audio - GAP/SEC/SEM/BI-13-C - GAP/BIS/BBM/BV-01-C - GAP/BIS/BSE/BV-01-C Signed-off-by: Dobrynin, Artur <[email protected]>
m-alperen-sener
requested changes
Aug 11, 2025
|
|
||
|
|
||
| def hdl_wid_350(_: WIDParams): | ||
| # Please synchronize with Broadcast ISO request. |
Collaborator
There was a problem hiding this comment.
Can you add comment here why we return true by default here.
| # Please click OK when IUT establishes BIG sync, and ready to receive ISO data. | ||
| stack = get_stack() | ||
| btp.gap_iso_sync_big() | ||
| is_con = stack.gap.gap_wait_for_iso_channel_status(types.IsoChannelStatus.CONNECTED) |
Collaborator
There was a problem hiding this comment.
Suggested change
| is_con = stack.gap.gap_wait_for_iso_channel_status(types.IsoChannelStatus.CONNECTED) | |
| return stack.gap.gap_wait_for_iso_channel_status(types.IsoChannelStatus.CONNECTED) |
|
|
||
|
|
||
| def hdl_wid_353(_: WIDParams): | ||
| # Please configure IUT security to Mode 3 Level 2 or Level 3. |
Collaborator
There was a problem hiding this comment.
Same here, I think it is better to leave comment why we return true without actually doing nothing.
|
|
||
|
|
||
| def hdl_wid_356(_: WIDParams): | ||
| # Please broadcast valid ISO data packets (more than 3 packets). |
Collaborator
There was a problem hiding this comment.
It is Ok as it is, but I wonder if we can retrieve min number of packets required to send from description and use it in code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests added in PTS with ICS Audio