app: Add module for sending AT commands from buttons #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow AT commands to be send for each of the nRF9151DK buttons. Total of 4 different AT commands that can be set using Kconfig. Intention is the help testing specific error cases that are otherwise hard to produce. Signed-off-by: Seppo Takalo <[email protected]>
SeppoTakalo
force-pushed
the
debug_buttons
branch
from
e488f94 to
6a959e4
Compare
|
|
||
| endif # SM_GNSS | ||
|
|
||
| config SM_BUTTONS |
Contributor
There was a problem hiding this comment.
Should we have a separate Kconfig.debug for these kind of things?
Or somehow indicate that this is for debug functionality. SM_DEBUG_BUTTONS?
|
|
||
| if SM_BUTTONS | ||
|
|
||
| config SM_BUTTON0_AT |
Contributor
There was a problem hiding this comment.
Given that DTR is tied to button0 without any overlays, this can only be used with external overlay. Would it be better to only have this for 3 buttons and mention that for button0 you can do this, but only with external overlay?
| default "AT+CFUN=4" | ||
|
|
||
| config SM_BUTTON1_AT | ||
| string "AT command for button 1" |
Contributor
There was a problem hiding this comment.
Should these be the DK or DTS numbers? With DK this is button 2.
trantanen
requested changes
Dec 23, 2025
Collaborator
trantanen
left a comment
trantanen
left a comment
There was a problem hiding this comment.
Let's discuss this debug feature after the holiday period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow AT commands to be send for each of the nRF9151DK buttons. Total of 4 different AT commands that can be set using Kconfig.
Intention is the help testing specific error cases that are otherwise hard to produce.