Skip to content

manifest: add allowlist filtering#71

Merged
trantanen merged 1 commit intonrfconnect:mainfrom
hlord2000:manifest/allowlist
Mar 19, 2026
Merged

manifest: add allowlist filtering#71
trantanen merged 1 commit intonrfconnect:mainfrom
hlord2000:manifest/allowlist

Conversation

@hlord2000
Copy link
Contributor

Add allowlist filtering for faster initialization. May be able to improve by excluding other irrelevant Zephyr projects like lvgl, zscilib, etc.

@hlord2000 hlord2000 marked this pull request as draft November 10, 2025 17:04
Copy link
Collaborator

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlord2000 What's your plan on this? I think we could take this into use. Needs a rebase though.

@hlord2000 hlord2000 force-pushed the manifest/allowlist branch from 6e55a2b to 20675b1 Compare March 5, 2026 18:07
@hlord2000
Copy link
Contributor Author

@hlord2000 What's your plan on this? I think we could take this into use. Needs a rebase though.

Just rebased, ran tests locally. Working well now and much faster to clone.

@hlord2000 hlord2000 marked this pull request as ready for review March 5, 2026 18:07
@hlord2000 hlord2000 force-pushed the manifest/allowlist branch 3 times, most recently from 244613b to bd449ab Compare March 11, 2026 15:30
@trantanen
Copy link
Collaborator

Compliance seems to miss some missing Kconfig although compilation works fine. I didn't have time to check what to do with that. Whether we'd just need to ignore some Kconfig check in compliance workflow.

@trantanen
Copy link
Collaborator

The improvement I got for running west update:
Original:

real	6m5.247s
user	4m52.668s

This PR:

real	2m57.314s
user	2m5.755s

And the folder sizes are:
5487680 before
3155408 after

@trantanen
Copy link
Collaborator

I verified this with our nightly CI tests and everything works fine.
Need to see what to do with compliance still...

trantanen added a commit to trantanen/ncs-serial-modem that referenced this pull request Mar 19, 2026
Exclude some Kconfig checks because they alert missing Kconfigs from
modules that are not in the "allowlist" of the west.yml so
these are false alerts. "allowlist" taken into use in PR nrfconnect#71.

Signed-off-by: Tommi Rantanen <[email protected]>
trantanen added a commit that referenced this pull request Mar 19, 2026
Exclude some Kconfig checks because they alert missing Kconfigs from
modules that are not in the "allowlist" of the west.yml so
these are false alerts. "allowlist" taken into use in PR #71.

Signed-off-by: Tommi Rantanen <[email protected]>
Add allowlist filtering for faster initialization.
May be able to improve by excluding other irrelevant
Zephyr projects like lvgl, zscilib, etc.

Signed-off-by: Helmut Lord <[email protected]>
@trantanen trantanen force-pushed the manifest/allowlist branch from bd449ab to f2287d2 Compare March 19, 2026 13:16
@trantanen
Copy link
Collaborator

I tried to figure out how to get rid of the compliance issues with Kconfig references to Kconfigs that are in modules that are not in the allowlist. I couldn't find any other way than just exclude those Kconfig checks. That is handled in PR #222.

I have rebased this PR now and compliance seems to pass. I will merge once the build is through too.

@trantanen trantanen merged commit cc886f7 into nrfconnect:main Mar 19, 2026
3 checks passed
@trantanen trantanen added the backport v1-branch Backport the PR to main branch. label Mar 23, 2026
trantanen added a commit to trantanen/ncs-serial-modem that referenced this pull request Mar 24, 2026
Exclude some Kconfig checks because they alert missing Kconfigs from
modules that are not in the "allowlist" of the west.yml so
these are false alerts. "allowlist" taken into use in PR nrfconnect#71.

Signed-off-by: Tommi Rantanen <[email protected]>
trantanen added a commit that referenced this pull request Mar 24, 2026
Exclude some Kconfig checks because they alert missing Kconfigs from
modules that are not in the "allowlist" of the west.yml so
these are false alerts. "allowlist" taken into use in PR #71.

Signed-off-by: Tommi Rantanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport v1-branch Backport the PR to main branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants