bluetooth: services: misc cleanup and changes #585
+214
−361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
lemrey
force-pushed
the
services-cleanup
branch
2 times, most recently
from
92761c1 to
1b81cd8
Compare
lemrey
force-pushed
the
services-cleanup
branch
3 times, most recently
from
f01a41e to
ad177b5
Compare
lemrey
force-pushed
the
services-cleanup
branch
2 times, most recently
from
09cfa57 to
29fae85
Compare
Remove stray doxygen comment. Signed-off-by: Emanuele Di Santo <[email protected]>
lemrey
force-pushed
the
services-cleanup
branch
from
29fae85 to
444ec99
Compare
lemrey
force-pushed
the
services-cleanup
branch
3 times, most recently
from
8663a9b to
b451cef
Compare
github-actions
bot
added
doc-required
lemrey
force-pushed
the
services-cleanup
branch
from
b451cef to
fa25d23
Compare
Remove outdated doxygen documentation. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove unnecessary cast. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove unnecessary cast. Signed-off-by: Emanuele Di Santo <[email protected]>
Do not translate the errors from SoftDevice calls, instead return those directly. Signed-off-by: Emanuele Di Santo <[email protected]>
SoftDevice will return an error if they are not, no need to check that ourselves in the service implementation. Signed-off-by: Emanuele Di Santo <[email protected]>
Use compound literal for the notification size. Signed-off-by: Emanuele Di Santo <[email protected]>
lemrey
force-pushed
the
services-cleanup
branch
from
fa25d23 to
1499b96
Compare
This function is mostly called automatically by the SoftDevice handler, so only assert if the parameters are NULL. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove NULL checks in the BLE event handler. This handler is mostly called by the SoftDevice handler automatically, just use asserts. Signed-off-by: Emanuele Di Santo <[email protected]>
Rename to `nus_instance` for clarity and consistency with other services. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove checks on the parameters to the SoftDevice _hvx() call. All SoftDevice APIs implement error checking already, just call the SoftDevice function directly. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove error translation for the SoftDevice _hvx() call. Return the SoftDevice error directly. The return value of the call invoking _hvx() is anyway only checked against zero, its actual value is not used. Signed-off-by: Emanuele Di Santo <[email protected]>
lemrey
force-pushed
the
services-cleanup
branch
from
1499b96 to
64ddc08
Compare
lemrey
commented
Jan 7, 2026
Comment on lines
-290
to
-295
| case NRF_SUCCESS: | ||
| if (hvx_len != len) { | ||
| LOG_ERR("Notified %d of %d bytes", hvx_len, len); | ||
| return NRF_ERROR_INVALID_PARAM; | ||
| } | ||
| return NRF_SUCCESS; |
Contributor
Author
There was a problem hiding this comment.
This is a change in behavior, where earlier we returned an error now we return success.
lemrey
commented
Jan 9, 2026
Comment on lines
-314
to
-329
| if (*len > BLE_NUS_MAX_DATA_LEN) { | ||
| return NRF_ERROR_INVALID_PARAM; | ||
| } | ||
|
|
||
| if (conn_handle == BLE_CONN_HANDLE_INVALID) { | ||
| return NRF_ERROR_NOT_FOUND; | ||
| } | ||
|
|
||
| ctx = ble_nus_client_context_get(nus, conn_handle); | ||
| if (ctx == NULL) { | ||
| return NRF_ERROR_NOT_FOUND; | ||
| } | ||
|
|
||
| if (!ctx->is_notification_enabled) { | ||
| return NRF_ERROR_INVALID_PARAM; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is also gone and a change in behavior
lemrey
commented
Jan 9, 2026
Contributor
Author
lemrey
left a comment
lemrey
left a comment
There was a problem hiding this comment.
There will be a follow up PR to update samples not to send notifications blindly. There were a bunch of checks in the application and in the service to ignore / override errors. This patch removes such checks in the services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.