bluetooth: services: ble_mcumgr: remove logic around notifications #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
Contributor
|
@lemrey Please rebase :) |
The service is maintaining information about whether the notifications are enabled or not, but it is not using that information for any purpose. Additionally, this logic is maintained per link thus requiring to handle multiple contexts. This patch removes the logic around notifications, thus simplifying the implementation. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove unused variable. Signed-off-by: Emanuele Di Santo <[email protected]>
anhmolt
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service is maintaining information about whether the notifications are enabled or not, but it is not using that information for any purpose. Additionally, this logic is maintained per link thus requiring to handle
multiple contexts. This patch removes the logic around notifications, thus simplifying the implementation.