Skip to content

samples: Cleanup prj.conf files #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eivindj-nordic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

samples: Cleanup prj.conf files #602

eivindj-nordic wants to merge 1 commit into from

Conversation

@eivindj-nordic
Copy link
Contributor

@eivindj-nordic eivindj-nordic commented Jan 8, 2026 •
edited by anhmolt
Loading

@eivindj-nordic eivindj-nordic self-assigned this Jan 8, 2026
@eivindj-nordic eivindj-nordic requested review from a team and rghaddab as code owners January 8, 2026 09:24
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

You can find the documentation preview for this PR here.

@eivindj-nordic eivindj-nordic requested review from a team as code owners January 8, 2026 11:02
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 8, 2026
@nordicjm
Copy link
Contributor

nordicjm commented Jan 8, 2026

needs rebase

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed doc-required PR must not be merged without tech writer approval. labels Jan 8, 2026
@eivindj-nordic eivindj-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2026
nordicjm
nordicjm reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright is useless really, you can't copyright a bunch of Kconfig options in a list

samples/bluetooth/ble_bms/prj.conf Outdated
CONFIG_MBEDTLS_PSA_KEY_SLOT_COUNT=1
CONFIG_MBEDTLS_PSA_STATIC_KEY_SLOT_BUFFER_SIZE=65

#Advertising library
Copy link
Contributor

@nordicjm nordicjm Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

Copy link
Contributor Author

@eivindj-nordic eivindj-nordic Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added space and removed copyright.

@eivindj-nordic
Copy link
Contributor Author

eivindj-nordic commented Jan 9, 2026

The copyright is useless really, you can't copyright a bunch of Kconfig options in a list

It was already there in the boot samples, and in the samples I checked in NCS. Hence, it seemed like it was supposed to be there. Though I agree, I don't see the need for it.

@eivindj-nordic
samples: cleanup prj.conf files
20b65bd 
* Cleanup and alignment of prj-conf files.
* Remove license from prj.conf files. It is not needed for these files.

Signed-off-by: Eivind Jølsgard <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2026
@eivindj-nordic
Copy link
Contributor Author

eivindj-nordic commented Jan 9, 2026

@nrfconnect/ncs-eris Please review.

anhmolt
anhmolt reviewed Jan 9, 2026
View reviewed changes
samples/bluetooth/ble_cgms/prj.conf
Comment on lines +1 to +6
#
# Copyright (c) 2025 Nordic Semiconductor ASA
#
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
#

Copy link
Contributor

@anhmolt anhmolt Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from earlier. Should be removed.

Suggested change
#
# Copyright (c) 2025 Nordic Semiconductor ASA
#
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
#

samples/bluetooth/ble_cgms/prj.conf
Comment on lines 44 to 51
# BLE connection parameter
CONFIG_BLE_CONN_PARAMS=y
#This is not yet supported in S115
# Set minimum connection interval to 400ms
CONFIG_BLE_CONN_PARAMS_MIN_CONN_INTERVAL=6
# Set maximum connection interval to 650ms
CONFIG_BLE_CONN_PARAMS_MAX_CONN_INTERVAL=256
# Set supervision timeout to 4 seconds
CONFIG_BLE_CONN_PARAMS_SUP_TIMEOUT=400
Copy link
Contributor

@anhmolt anhmolt Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values in comments are outdated. Please update them or simply remove the comments (this is the only place we have this kind of comments).

Could remove the configurations also. Two of three are setting the value to the default value.

samples/boot/mcuboot_recovery_entry/prj.conf
Comment on lines -25 to +36
CONFIG_BLE_CONN_PARAMS_MAX_CONN_INTERVAL=256
CONFIG_BLE_CONN_PARAMS_MAX_CONN_INTERVAL=24
CONFIG_BLE_CONN_PARAMS_INITIATE_ATT_MTU_EXCHANGE=n
CONFIG_BLE_CONN_PARAMS_DATA_LENGTH_RX=251
CONFIG_BLE_CONN_PARAMS_DATA_LENGTH_TX=251
CONFIG_NRF_SDH_BLE_GAP_EVENT_LENGTH=10
CONFIG_BLE_CONN_PARAMS_SUP_TIMEOUT=20
CONFIG_BLE_CONN_PARAMS_MAX_SUP_TIMEOUT_DEVIATION=20
Copy link
Contributor

@anhmolt anhmolt Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supervision timeout options can be moved up and placed after CONFIG_BLE_CONN_PARAMS_MAX_CONN_INTERVAL. They are all connected to the same negotiation procedure, while data length extension is another procedure.

samples/boot/mcuboot_recovery_retention/prj.conf
Comment on lines 3 to 5
#
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
#
Copy link
Contributor

@anhmolt anhmolt Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the license here as well?

Suggested change
#
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
#

samples/peripherals/lpuarte/prj.conf
# Clock control
CONFIG_CLOCK_CONTROL=y

# LPUARTE
Copy link
Contributor

@anhmolt anhmolt Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# LPUARTE
# Low Power UARTE

@anhmolt anhmolt changed the title samples: Add license to prj.conf files and cleanup samples: Remove license from prj.conf files and cleanup Jan 9, 2026
@anhmolt anhmolt changed the title samples: Remove license from prj.conf files and cleanup samples: Cleanup prj.conf files Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anhmolt anhmolt anhmolt left review comments

@lemrey lemrey lemrey approved these changes

@rghaddab rghaddab Awaiting requested review from rghaddab rghaddab is a code owner

@nordicjm nordicjm Awaiting requested review from nordicjm

At least 2 approving reviews are required to merge this pull request.

Assignees

@eivindj-nordic eivindj-nordic

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eivindj-nordic @nordicjm @lemrey @anhmolt