Update Kconfig dependencies #603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
eivindj-nordic
force-pushed
the
kconfig_dependencies
branch
from
73267bb to
8616910
Compare
github-actions
bot
added
doc-required
|
You can find the documentation preview for this PR here. |
nordicjm
requested changes
Jan 8, 2026
eivindj-nordic
force-pushed
the
kconfig_dependencies
branch
from
8616910 to
8c61231
Compare
nordicjm
approved these changes
Jan 8, 2026
anhmolt
reviewed
Jan 9, 2026
Contributor
anhmolt
left a comment
anhmolt
left a comment
There was a problem hiding this comment.
Good. Left some comments.
drivers/bm_lpuarte/Kconfig
Outdated
Comment on lines
10
to
11
| depends on NRFX_UARTE | ||
| depends on NRFX_GPIOTE |
Contributor
There was a problem hiding this comment.
Suggested change
| depends on NRFX_UARTE | |
| depends on NRFX_GPIOTE | |
| depends on NRFX_GPIOTE | |
| depends on NRFX_UARTE |
lib/bluetooth/ble_adv/Kconfig
Outdated
|
|
||
| menuconfig BLE_ADV | ||
| bool "Bluetooth LE Advertising" | ||
| depends on SOFTDEVICE |
Contributor
There was a problem hiding this comment.
Suggested change
| depends on SOFTDEVICE | |
| depends on SOFTDEVICE_PERIPHERAL |
Comment on lines
7
to
+10
| menuconfig BLE_SCAN | ||
| bool "Bluetooth LE Scan [EXPERIMENTAL]" | ||
| depends on SOFTDEVICE_CENTRAL | ||
| depends on NRF_SDH_BLE |
Contributor
There was a problem hiding this comment.
Suggested change
| menuconfig BLE_SCAN | |
| bool "Bluetooth LE Scan [EXPERIMENTAL]" | |
| depends on SOFTDEVICE_CENTRAL | |
| depends on NRF_SDH_BLE | |
| menuconfig BLE_SCAN | |
| bool "Bluetooth LE Scan [EXPERIMENTAL]" | |
| depends on SOFTDEVICE_CENTRAL | |
| depends on NRF_SDH_BLE | |
| depends on BLE_ADV_DATA |
| depends on NRF_SDH | ||
| depends on NRF_SDH_BLE |
Contributor
There was a problem hiding this comment.
Suggested change
| depends on NRF_SDH | |
| depends on NRF_SDH_BLE | |
| depends on NRF_SDH_BLE |
| menuconfig BLE_MCUMGR | ||
| bool "MCUmgr service" | ||
| depends on SOFTDEVICE_PERIPHERAL | ||
| depends on NRF_SDH |
Contributor
There was a problem hiding this comment.
Not needed I think. It's a dependency of NRF_SDH_BLE, but I cannot find any use of functions, macros or types from the nrf_sdh/nrf_sdh_soc APIs.
Suggested change
| depends on NRF_SDH |
Update Kconfig dependencies. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
kconfig_dependencies
branch
from
8c61231 to
ea14b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.