samples: use k_cpu_idle() instead of WFE, SEV, WFE pattern
#604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use k_cpu_idle() instead of the WFE, SEV, WFE pattern. k_cpu_idle() uses WFI underneath which is simpler than WFE and should be good enough for our purposes since we are using only one core and nothing is sending events using SEV. Although k_cpu_idle() masks all interrupts using PRIMASK, it has a predictable latency before re-enabling them, so it should not affect SoftDevice operation. Signed-off-by: Emanuele Di Santo <[email protected]>
github-actions
bot
added
the
changelog-entry-required
Contributor
|
I was expecting a manifest update with these changes? Or was that only for sleep? |
|
You can find the documentation preview for this PR here. |
Contributor
Author
That only affects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
k_cpu_idle()instead of theWFE,SEV,WFEpattern.k_cpu_idle()usesWFIunderneath which is simpler thanWFEand should be good enough for our purposes since we are only using one core and nothing is sending events usingSEV.Although
k_cpu_idle()masks all interrupts usingPRIMASK, it has minimal and predictable latency before re-enabling them, so it should not affect SoftDevice operation.