samples: use log_flush() instead of looping log_process()
#605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use log_flush() directly, which processes all logs. Signed-off-by: Emanuele Di Santo <[email protected]>
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
anhmolt
approved these changes
Jan 9, 2026
Contributor
anhmolt
left a comment
anhmolt
left a comment
There was a problem hiding this comment.
Looks good 👍
log_flush() is the same as while (LOG_PROCESS()) {} when multithreading is disabled. Changelog entry is not needed in my opinion.
lemrey
removed
the
changelog-entry-required
Contributor
|
@nrfconnect/ncs-eris Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
log_flush()directly, which processes all logs.