Skip to content

cmake/sysbuild/image_signing: allow usage --rom-fixed for images target partition recognition #23242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nvlsianpu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

cmake/sysbuild/image_signing: allow usage --rom-fixed for images target partition recognition #23242

nvlsianpu wants to merge 3 commits into from

Conversation

@nvlsianpu
Copy link
Contributor

@nvlsianpu nvlsianpu commented Jul 9, 2025

No description provided.

@nvlsianpu nvlsianpu requested review from a team as code owners July 9, 2025 15:30
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 9, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 9, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/sdk-mcuboot@6256d9f (main) nrfconnect/sdk-mcuboot#461 nrfconnect/sdk-mcuboot#461/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 9, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 14

Inputs:

Sources:

sdk-nrf: PR head: e56bb8bc2af9fb94dd0fc6d1dfe0a7047eac557e
mcuboot: PR head: 64352790f0b41b13195a7011ed8d0f68310afb14

more details

sdk-nrf:

PR head: e56bb8bc2af9fb94dd0fc6d1dfe0a7047eac557e
merge base: 50c7cef2422ad794c8856778e9895da158b00fb6
target head (main): 50c7cef2422ad794c8856778e9895da158b00fb6
Diff

mcuboot:

PR head: 64352790f0b41b13195a7011ed8d0f68310afb14
merge base: 6256d9f6df644231fd196c94a5a92f23c1ad24d4
target head (main): 6256d9f6df644231fd196c94a5a92f23c1ad24d4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── bootutil
│  │  │  │  ├── src
│  │  │  │  │  │ loader.c
│  │  │  ├── zephyr
│  │  │  │  │ Kconfig
cmake
│  ├── sysbuild
│  │  ├── b0_mcuboot_signing.cmake
│  │  ├── image_signing.cmake
│  │  │ image_signing_firmware_loader.cmake
sysbuild
│  │ CMakeLists.txt
west.yml

Outputs:

Toolchain

Version: f66cf421f3
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f66cf421f3_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-apps
    • ❌ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ❌ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps-main
    • ✅ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

You can find the documentation preview for this PR here.

nordicjm
nordicjm reviewed Jul 14, 2025
View reviewed changes
@nvlsianpu nvlsianpu force-pushed the signing-rom-fixed-all branch 3 times, most recently from 4011874 to b91ac43 Compare July 24, 2025 11:58
nvlsianpu
nvlsianpu commented Jul 24, 2025
View reviewed changes
cmake/sysbuild/image_signing.cmake Outdated
@@ -85,11 +87,9 @@ function(zephyr_mcuboot_tasks)
set(imgtool_sign ${PYTHON_EXECUTABLE} ${IMGTOOL} sign --version ${CONFIG_MCUBOOT_IMGTOOL_SIGN_VERSION} --align ${write_block_size} ${imgtool_sign_sysbuild})
else()
set(imgtool_rom_command)
Copy link
Contributor Author

@nvlsianpu nvlsianpu Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set(imgtool_rom_command)

nordicjm
nordicjm reviewed Jul 24, 2025
View reviewed changes
cmake/sysbuild/image_signing.cmake Outdated
Comment on lines 90 to 92
dt_chosen(code_partition PROPERTY "zephyr,code-partition")
dt_reg_addr(code_partition_offset PATH "${code_partition}" REQUIRED)
set(imgtool_rom_command --rom-fixed ${code_partition_offset})
Copy link
Contributor

@nordicjm nordicjm Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un-indent by 2 spaces

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 26, 2025

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot closed this Sep 3, 2025
@nvlsianpu nvlsianpu reopened this Sep 24, 2025
@de-nordic de-nordic force-pushed the signing-rom-fixed-all branch from b91ac43 to ed6594d Compare September 24, 2025 16:00
@de-nordic de-nordic removed the Stale label Sep 24, 2025
@de-nordic de-nordic force-pushed the signing-rom-fixed-all branch 8 times, most recently from 741ae76 to 47c69de Compare October 7, 2025 12:40
@de-nordic de-nordic force-pushed the signing-rom-fixed-all branch from 47c69de to b99e201 Compare October 7, 2025 14:11
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 7, 2025 •
edited
Loading

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9102[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5858[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9492[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23242/14)

@de-nordic de-nordic force-pushed the signing-rom-fixed-all branch 2 times, most recently from 37728f8 to 546da60 Compare October 7, 2025 14:22
@nvlsianpu @de-nordic
cmake/sysbuild/image_signing: added --rom-fixed for any image
7316207 
From now each image has populated fixed rom address in its header.
This sets fixed-rom flag and populated ih_load_address field in
the header.
This value can be used by MCUboot for deciding on image.

Signed-off-by: Andrzej Puzdrowski <[email protected]>
@nvlsianpu @de-nordic
cmake/sysbuild/image_signing_firmware_loader: fix missing img address…
0151a82 
… value

signing script on loader misses exact value for --rom-fixed parameter.

Signed-off-by: Andrzej Puzdrowski <[email protected]>
@nvlsianpu @de-nordic
manifest: update mcuboot
e56bb8b 
version which can use rom-fixed address for recognizing images.

Signed-off-by: Andrzej Puzdrowski <[email protected]>
@de-nordic de-nordic force-pushed the signing-rom-fixed-all branch from 546da60 to e56bb8b Compare October 10, 2025 19:27
@NordicBuilder NordicBuilder requested review from a team October 10, 2025 19:28
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nordicjm nordicjm nordicjm approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-mcuboot Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nvlsianpu @NordicBuilder @nordicjm @de-nordic