-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Quarantine: Workflows for notifications publishing #25502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 74bc1196990242e33557e745f466a3207de98224 more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)Outputs:ToolchainVersion: f911d4f4e7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
can be seen in action here PerMac#34 |
|
@nrfconnect/ncs-ci AFIK the sonnarcloud issue is that some regexes in the added python script can take a long time if some wrong values are passed there. But they only evaluate changes to the quarantine files in PRs in sdk-nrf, on github agents. I don't think it can be part of any DoS attack. Who can evaluate/discard those checks? |
40e648f to
0e3f446
Compare
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, ready_for_review] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could it be like in old workflow? So only if PR touches quarantine files this workflow runs:
paths:
- '**/scripts/quarantine*.yaml'
40a2d1a to
bec0cc2
Compare
| run: | | ||
| set -euo pipefail | ||
| PR_FILE="$(find ./quarantine-artifacts/pr -name 'pr_number.txt' -print -quit)" | ||
| if [[ -z "${PR_FILE}" || ! -s "${PR_FILE}" ]]; then | ||
| echo "ERROR: pr_number.txt not found or empty." >&2 | ||
| exit 1 | ||
| fi | ||
| PR_NUMBER="$(head -n1 "${PR_FILE}" | tr -d '\r')" | ||
| echo "PR_NUMBER=${PR_NUMBER}" >> "$GITHUB_ENV" |
Check failure
Code scanning / CodeQL
Environment variable built from user-controlled sources
669afaf to
bc54b01
Compare
Test Signed-off-by: Katarzyna Giadla <[email protected]>
This reverts commit a8ea238.
Add github workflows and python script responsible for publishing a comment with notifications for codeowners whenever an item under their ownership is added/removed into the quarantine file.