Add nrf52840dk/nrf52840/matter board variant and configuration #25646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
added
the
changelog-entry-required
Contributor
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: d0d5d0758e1e2db0e17838e664669291578463e9 more detailssdk-nrf:
matter:
Github labels
List of changed files detected by CI (217)Outputs:ToolchainVersion: f911d4f4e7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Contributor
|
What is the story behind this PR? Do we need a new board target in order to stop using PM in the future? And why is it only for nRF52840? |
Contributor
|
Suggest to have nrf54l15 or nrf54lm20a if you want to check if the changes affect sample within the Jenkins Integration plan (due to you resource constraints, on-target tests are limited to nrf54lm20dk, nrf54l15dk and nrf7002dk platforms) |
Contributor
Author
This should have been opened as draft with just @rghaddab added but I opened it as ready for review by mistake. It shows an initial port for the nrf52840 only, it doesn't work because of 2 matter bugs (referenced above) which include non-existent SUIT/PM things |
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
from
fdcfe40 to
f4ba2c5
Compare
Contributor
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
from
f4ba2c5 to
3b780a5
Compare
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
from
3b780a5 to
345b027
Compare
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
from
345b027 to
627a0ad
Compare
NordicBuilder
added
doc-required
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
2 times, most recently
from
8fb06c1 to
348b2bb
Compare
NordicBuilder
added
the
changelog-entry-required
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
8 times, most recently
from
39e18bc to
9147963
Compare
Contributor
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-25646/63) |
ArekBalysNordic
requested changes
Dec 30, 2025
sysbuild/Kconfig.matter
Outdated
| Enables merging the generated factory data with the merged.hex output build file. As a | ||
| result, the merged.hex build output file, which is used when flashing the firmware using | ||
| the west tool, includes the factory data as well. | ||
| #config MATTER_FACTORY_DATA_MERGE_WITH_FIRMWARE |
Contributor
There was a problem hiding this comment.
We must have this option.
|
|
||
| # Do not apply shield or snippets for the factory data partition and use an empty file for the | ||
| # board defconfig file | ||
| set(BOARD_DEFCONFIG ${CMAKE_CURRENT_SOURCE_DIR}/prj.conf) |
Contributor
There was a problem hiding this comment.
This approach makes no sense. There are only weird hacks and overrides for the process that relies only on CMAKE.
I don't see any advantage in creating a separate image for factory data. This only creates many redundant files in the build directory.
Instead align this PR to this approach: #26394
Contributor
Author
There was a problem hiding this comment.
This approach makes no sense. There are only weird hacks and overrides for the process that relies only on CMAKE.
You're not a build system maintainer, these are not hacks.
I don't see any advantage in creating a separate image for factory data. This only creates many redundant files in the build directory.
Instead align this PR to this approach: #26394
This is the approach and this is how it is going to be done, just like it is for other images and other systems e.g. in zephyr, in bare metal, etc.
Contributor
There was a problem hiding this comment.
You're not a build system maintainer, these are not hacks.
Similarly, it's not within your scope to decide how Matter factory data should work, as you're not the Matter maintainer. This solution was only mentioned but never consulted with us.
This is the approach and this is how it is going to be done, just like it is for other images and other systems e.g. in zephyr, in bare metal, etc.
Can you point me to where this was decided and by whom? I'm curious why I wasn't consulted on this.
Fixes an invalid path to a source file Signed-off-by: Jamie McCrae <[email protected]>
Includes changes for partition removal Signed-off-by: Jamie McCrae <[email protected]>
This adds an image which sysbuild can add which simply flashes a hex file Signed-off-by: Jamie McCrae <[email protected]>
Adds dtsi files which can be included and set the partition layout up for the matter samples Signed-off-by: Jamie McCrae <[email protected]>
Includes nrf52840dk, nrf54l15dk (secure only) and nrf54lm20dk Signed-off-by: Jamie McCrae <[email protected]>
We need to use the new CONFIG_CHIP_APP_ZAP_DIR to set the proper path to the custom zap-generated directory in Matter stack. Signed-off-by: Arkadiusz Balys <[email protected]>
TF-M is currently not supported without partition manager, do not force disabling PM if a non-secure board target is used in samples that build for these Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
from
fb701f7 to
761e400
Compare
NordicBuilder
added
doc-required
Allows generating and flashing the nrf70 firmware in applications which do not use partition manager, and will be flashed when west flash is invoked Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
matter_nrf52840dk_no_pm
branch
from
761e400 to
d0d5d07
Compare
NordicBuilder
added
changelog-entry-required
|
You can find the documentation preview for this PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes configuration for matter samples also
Blocked by NCSDK-36367 and NCSDK-36368