Skip to content

[Backport ncs-v3.2-branch] Fix i2c driver for TWI on nRF52 #26249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nika-nordic wants to merge 1 commit into
base: v3.2-branch
Choose a base branch
from
Open

[Backport ncs-v3.2-branch] Fix i2c driver for TWI on nRF52 #26249

nika-nordic wants to merge 1 commit into from

Conversation

@nika-nordic
Copy link
Contributor

@nika-nordic nika-nordic commented Dec 12, 2025

Obsolete nrfx error code was used causing operations to report failure despite success.

@nika-nordic
manifest: update sdk-zephyr to have i2c fixes for nRF52 twi
f049b5a 
Obsolete nrfx error code was used causing operations to report
failure despite success.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic nika-nordic requested review from a team as code owners December 12, 2025 14:35
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 12, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 12, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@ec78104 (ncs-v3.2-branch) nrfconnect/sdk-zephyr#3630 nrfconnect/sdk-zephyr#3630/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@shanthanordic shanthanordic added this to the 3.2.2 milestone Dec 12, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 12, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: f049b5a43afdbbe912475f991121f1ddee34e01f
zephyr: PR head: 3ebc0f6bb8baf40a5460ec96e484c156ef0a7e8e

more details

sdk-nrf:

PR head: f049b5a43afdbbe912475f991121f1ddee34e01f
merge base: 802b7f56306d8f2eafab7275d476b4a7aec33c2e
target head (v3.2-branch): 802b7f56306d8f2eafab7275d476b4a7aec33c2e
Diff

zephyr:

PR head: 3ebc0f6bb8baf40a5460ec96e484c156ef0a7e8e
merge base: ec78104f15691cccd94682cf4b22e0a013f28dd8
target head (ncs-v3.2-branch): ec78104f15691cccd94682cf4b22e0a013f28dd8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (13) 
west.yml
zephyr
│  ├── drivers
│  │  ├── i2c
│  │  │  ├── i2c_nrfx_twi.c
│  │  │  ├── i2c_nrfx_twi_common.h
│  │  │  │ i2c_nrfx_twi_rtio.c
│  │  ├── usb
│  │  │  ├── common
│  │  │  │  ├── nrf_usbd_common
│  │  │  │  │  ├── nrf_usbd_common.c
│  │  │  │  │  │ nrf_usbd_common.h
│  │  │  ├── device
│  │  │  │  │ usb_dc_nrfx.c
│  ├── modules
│  │  ├── hal_nordic
│  │  │  ├── nrfx
│  │  │  │  │ nrfx_glue.h
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── controller
│  │  │  │  ├── ll_sw
│  │  │  │  │  ├── nordic
│  │  │  │  │  │  ├── hal
│  │  │  │  │  │  │  ├── nrf5
│  │  │  │  │  │  │  │  ├── radio
│  │  │  │  │  │  │  │  │  │ radio.c
│  ├── tests
│  │  ├── boards
│  │  │  ├── nrf
│  │  │  │  ├── i2c
│  │  │  │  │  ├── i2c_slave
│  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  │  │  ├── nrf52840dk_nrf52840_common.overlay
│  │  │  │  │  │  │  │ nrf52840dk_nrf52840_twi.overlay
│  │  │  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 43683a87ea
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:43683a87ea_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1506
    • sdk-zephyr test count: 774
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-sdk-find-my
    • ✅ test-low-level
    • ✅ test-sdk-dfu
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

You can find the documentation preview for this PR here.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 12, 2025

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.uart[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 2464[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52833]: ROM size increased by 2384[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_ram_load[nrf54lm20dk/nrf54lm20a/cpuapp]: RAM size increased by 1300[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_ram_load[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 1220[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: ROM size increased by 2444[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 1240[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_4llpmconn[nrf52840dongle/nrf52840]: ROM size increased by 2380[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: ROM size increased by 2452[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1256[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.find_my.switchable_networks.release.dfu_switch.apple[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 1108[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_nrf21540ek_multicore[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 2304[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_keyboard[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 728[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840dongle/nrf52840]: ROM size increased by 2356[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 1404[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_ram_load.uart[nrf54lm20dk/nrf54lm20a/cpuapp]: RAM size increased by 2552[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_ram_load.uart[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 2472[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52840dongle/nrf52840]: ROM size increased by 1120[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle[nrf52840dk/nrf52840]: ROM size increased by 2352[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1420[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_nrf21540ek[nrf52840dk/nrf52840]: ROM size increased by 2424[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52833dk/nrf52820]: ROM size increased by 592[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_dongle[[email protected]/nrf54h20/cpuapp]: ROM size increased by 656[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 2296[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle.uart[[email protected]/nrf54h20/cpuapp]: ROM size increased by 1356[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard.uart[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 2424[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 924[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_fast_pair.keyboard[nrf52kbd/nrf52832]: ROM size increased by 720[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.find_my.switchable_networks.release.dfu_switch.google[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 1100[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.find_my.switchable_networks.release.ui_switch[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 1108[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.smp_svr_mini_boot[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 1416[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-eris @robertstypa @maciejpietras)
applications.nrf_desktop.zdebug.uart[nrf54l15dk/nrf54l10/cpuapp]: ROM size increased by 2424[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52820dongle/nrf52820]: ROM size increased by 600[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52820]: ROM size increased by 584[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_fast_pair.gmouse[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 660[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.find_my.switchable_networks.release.dfu_switch[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 1096[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840dongle/nrf52840]: ROM size increased by 2384[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54h20/cpuapp]: ROM size increased by 1300[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: ROM size increased by 1432[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: ROM size increased by 2488[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.bluetooth.fast_pair.locator_tag.release[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 1200[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52840dk/nrf52840]: ROM size increased by 2440[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52dmouse/nrf52832]: ROM size increased by 1436[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52kbd/nrf52832]: ROM size increased by 740[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle.usb_next[nrf52840dk/nrf52840]: ROM size increased by 2396[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard.uart[nrf54l15dk/nrf54l10/cpuapp]: ROM size increased by 2424[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 2424[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size increased by 2448[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: ROM size increased by 1432[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[[email protected]/nrf54h20/cpuapp]: ROM size increased by 648[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug[nrf52833dongle/nrf52833]: ROM size increased by 2392[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_mcuboot_qspi[nrf52840dk/nrf52840]: ROM size increased by 2448[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 1216[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.bluetooth.fast_pair.locator_tag.release[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 1176[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_fast_pair.gmouse.uart[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 3788[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 2376[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_wwcb[nrf52840dk/nrf52840]: ROM size increased by 2444[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
sample.find_my.switchable_networks.release.ui_switch[nrf54l15dk/nrf54l10/cpuapp]: ROM size increased by 1100[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_fast_pair.gmouse.uart[nrf54l15dk/nrf54l10/cpuapp]: ROM size increased by 3788[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_mcuboot_smp[nrf52840dk/nrf52840]: ROM size increased by 2408[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52820dongle/nrf52820]: ROM size increased by 588[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: ROM size increased by 1264[B] in comparison to the main[af543b6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-26249/1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rugeGerritsen rugeGerritsen rugeGerritsen approved these changes

@jostn jostn Awaiting requested review from jostn

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

4 participants

@nika-nordic @NordicBuilder @rugeGerritsen @shanthanordic