-
Notifications
You must be signed in to change notification settings - Fork 1.4k
nrf_security: CRACEN: Added support for PKE memory clear. #26282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nrf_security: CRACEN: Added support for PKE memory clear. #26282
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 85e1662af09c2eb4a3e9b9bcfc428d762d54331d more detailssdk-nrf:
Github labels
List of changed files detected by CI (5)Outputs:ToolchainVersion: 400c6cb4ec Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
fe77d40 to
ed10c24
Compare
ed10c24 to
cea0972
Compare
cea0972 to
5006567
Compare
5006567 to
3228d85
Compare
degjorva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question, but looks good
| pkreq = sx_pk_acquire_req(SX_PK_CMD_CLEAR_MEMORY); | ||
|
|
||
| sx_pk_run(pkreq.req); | ||
| sx_pk_wait(pkreq.req); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this return an error? I don't know if this command can fail or not
3228d85 to
0a35381
Compare
0a35381 to
dca9303
Compare
dca9303 to
8706ba3
Compare
8706ba3 to
90662a8
Compare
1a138e1 to
2a7bb81
Compare
2a7bb81 to
af44212
Compare
af44212 to
afd8a5b
Compare
frkv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM (with polling instead of IRQ)
afd8a5b to
3098f3c
Compare
3098f3c to
afa10b3
Compare
afa10b3 to
e93d10a
Compare
1390d59 to
8949cc0
Compare
degjorva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might possibly still need to use polling, but we will see what CI says
Jira: NCSDK-36624 Signed-off-by: Andrei Urs-Hadadea <[email protected]>
8949cc0 to
85e1662
Compare
Added support for PKE memory clear in CRACEN.
Jira: NCSDK-36624