-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Enable TF-M system off in compatible tests and samples #26418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables TF-M system off functionality for NRF54L15/L10/LV10 devices in non-secure (/ns) configurations across compatible tests and samples. The changes add support for non-secure variants of these platforms and configure them with the necessary TF-M settings.
- Adds
/cpuapp/nsplatform variants to test and sample configurations for nrf54l15dk and nrf54lv10dk devices - Creates board-specific configuration files enabling TF-M system off service for non-secure builds
- Removes obsolete GPIO wakeup overlay files that are no longer needed
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/benchmarks/current_consumption/system_off/testcase.yaml | Adds non-secure platform variants and removes deprecated extra_args for GPIO overlays |
| tests/benchmarks/current_consumption/system_off/boards/nrf54lv10dk_nrf54lv10a_cpuapp_gpio_wakeup.overlay | Deletes obsolete GPIO wakeup overlay configuration |
| tests/benchmarks/current_consumption/system_off/boards/nrf54lm20dk_nrf54lm20a_cpuapp_gpio_wakeup.overlay | Deletes obsolete GPIO wakeup overlay configuration |
| tests/benchmarks/current_consumption/system_off/boards/nrf54l15dk_nrf54l15_cpuapp_ns.conf | Adds TF-M configuration for nrf54l15 non-secure builds |
| tests/benchmarks/current_consumption/system_off/boards/nrf54l15dk_nrf54l15_cpuapp_gpio_wakeup.overlay | Deletes obsolete GPIO wakeup overlay configuration |
| tests/benchmarks/current_consumption/system_off/boards/nrf54l15dk_nrf54l10_cpuapp_ns.conf | Adds TF-M configuration for nrf54l10 non-secure builds |
| samples/bluetooth/peripheral_power_profiling/sample.yaml | Adds non-secure platform support for power profiling sample |
| samples/bluetooth/peripheral_power_profiling/boards/nrf54l15dk_nrf54l15_cpuapp_ns.conf | Adds board configuration for nrf54l15 non-secure power profiling |
| samples/bluetooth/peripheral_power_profiling/boards/nrf54l15dk_nrf54l10_cpuapp_ns.conf | Adds board configuration for nrf54l10 non-secure power profiling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2d136a03a473f02834e26231c49908de316ff03c more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)Outputs:ToolchainVersion: f911d4f4e7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
| - nrf54l15dk/nrf54l10/cpuapp | ||
| - nrf54l15dk/nrf54l15/cpuapp | ||
| - nrf54lm20dk/nrf54lm20a/cpuapp | ||
| - nrf54lv10dk/nrf54lv10a/cpuapp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not remove failing configuration, they are here to indicate that there is missing support for memory retention.
We want to continue testing it in quarantine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sure, I can add the nrf54lv10ns target there if that is what you prefer to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the relevant commit for this as well
775c78d to
aaa86e9
Compare
Add support for the power profiling sample for the nrf54l15/l10 TF-M enabled (non-secure) targets. Ref: NCSDK-36560 Signed-off-by: Georgios Vasilakis <[email protected]>
Add support for the current_constumption system_off sample for the nrf54l15/l10/lv10 TF-M enabled (non-secure) targets. Ref: NCSDK-36560 Signed-off-by: Georgios Vasilakis <[email protected]>
aaa86e9 to
2d136a0
Compare
Enables the TF-M system of for the NRF54L15/L10/LV10 devices in compatible samples and tests.