Skip to content

Conversation

@nicu1989
Copy link
Contributor

@nicu1989 nicu1989 commented Jan 7, 2026

Since scancode-toolkit is not part of ncs sdk anymore, the user needs to install scancode manually.

Copilot AI review requested due to automatic review settings January 7, 2026 17:28
@nicu1989 nicu1989 requested a review from a team as a code owner January 7, 2026 17:28
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 7, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds user-friendly guidance for installing scancode-toolkit, which is no longer bundled with the NCS SDK. The change improves the error messaging when scancode is not found on the system.

Key Changes:

  • Added detection to check if scancode executable exists before attempting to run it
  • Provides clear installation instructions and troubleshooting steps when scancode is missing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 7, 2026

CI Information

To view the history of this post, click the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 59f479a338ea95d4f7131def15e7063141b49e97

more details

sdk-nrf:

PR head: 59f479a338ea95d4f7131def15e7063141b49e97
merge base: e5a583bd19720045cf898f8e0ea1d390adbd52ec
target head (main): 5c4e352fbbff14b2caa2990a9e51c9774e0ba2f2
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
scripts
│  ├── west_commands
│  │  ├── sbom
│  │  │  │ scancode_toolkit_detector.py

Outputs:

Toolchain

Version: f911d4f4e7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f911d4f4e7_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nicu1989 nicu1989 force-pushed the nicu1989_add_scancode_user_info branch 2 times, most recently from 14f89bf to 248222d Compare January 9, 2026 08:36
Copilot AI review requested due to automatic review settings January 9, 2026 08:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Since scancode-toolkit is not part of ncs sdk anymore,
the user needs to install scancode manually.

Signed-off-by: Nicolae Dicu <[email protected]>
@nicu1989 nicu1989 force-pushed the nicu1989_add_scancode_user_info branch from 248222d to 59f479a Compare January 9, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants