lib: lte_link_control: Add support for band list in LTE band lock #26434
Conversation
NordicBuilder
added
the
doc-required
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring LTE band lock using a comma-separated list of band numbers through a new CONFIG_LTE_LOCK_BAND_LIST Kconfig option, which can be used alongside or instead of the existing bit mask configuration.
Key changes:
- Introduces
CONFIG_LTE_LOCK_BAND_LISTfor list-based band configuration - Removes default value from
CONFIG_LTE_LOCK_BAND_MASKto require explicit configuration - Updates modem AT command to support both mask and list parameters when list is provided
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/lte_link_control/lte_lc_modem_hooks.c | Adds runtime logic to use band list parameter in AT command when configured, with build-time validation |
| lib/lte_link_control/Kconfig | Adds CONFIG_LTE_LOCK_BAND_LIST option and removes default from CONFIG_LTE_LOCK_BAND_MASK |
| doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst | Documents the new CONFIG_LTE_LOCK_BAND_LIST feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tokangas
force-pushed
the
lte_lc_band_lock_band_list_support
branch
from
a5fbcd1 to
5dae97a
Compare
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 8e72e17dd4c52b7451740a5673138fc3f82883ab more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: f911d4f4e7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
tokangas
force-pushed
the
lte_lc_band_lock_band_list_support
branch
from
5dae97a to
16c5717
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: |
peknis
left a comment
peknis
left a comment
There was a problem hiding this comment.
Approved with a couple of nits.
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
tokangas
force-pushed
the
lte_lc_band_lock_band_list_support
branch
from
16c5717 to
b629011
Compare
Added the CONFIG_LTE_LOCK_BAND_LIST Kconfig option for configuring LTE band lock using a list of band numbers. This can be used alone or combined with CONFIG_LTE_LOCK_BAND_MASK, which takes a bit string of enabled bands. Removed default value from the CONFIG_LTE_LOCK_BAND_MASK Kconfig option. When LTE band lock is enabled using CONFIG_LTE_LOCK_BANDS, also the bands need to be explicitly configured. It makes no sense to have a default list of bands which are enabled. Signed-off-by: Tommi Kangas <[email protected]>
tokangas
force-pushed
the
lte_lc_band_lock_band_list_support
branch
from
b629011 to
8e72e17
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 participants
Added the
CONFIG_LTE_LOCK_BAND_LISTKconfig option for configuring LTE band lock using a list of band numbers. This can be used alone or combined withCONFIG_LTE_LOCK_BAND_MASK, which takes a bit string of enabled bands.Removed default value from the
CONFIG_LTE_LOCK_BAND_MASKKconfig option. When LTE band lock is enabled usingCONFIG_LTE_LOCK_BANDS, also the bands need to be explicitly configured. It makes no sense to have a default list of bands which are enabled.