matter: samples: Fixes for Closure diagnostic clusters.

[ArekBalysNordic]

Thread Network Diagnostics:

• Wrong feature map
• Lack of attributes - enabled all possible
• Lack of reset-count command

Software Diagnostics:

• Disabled HighWatermarks attribute
• Disabled Thread Metrics

[Copilot]

Pull request overview

This PR fixes configuration issues in the Thread Network Diagnostics and Software Diagnostics clusters for the Matter closure sample. The primary purpose is to correct the Thread Network Diagnostics cluster by enabling its full feature set and properly configuring its ResetCounts command, while streamlining the Software Diagnostics cluster by removing unnecessary attributes.

Key changes:

• Transferred the ResetCounts command from Software Diagnostics to Thread Network Diagnostics cluster
• Added 33 additional diagnostic attributes to Thread Network Diagnostics (network metrics, role counters, transmission/reception statistics)
• Updated Thread Network Diagnostics FeatureMap from 0 to 15 to reflect enabled features
• Removed ThreadMetrics and heap monitoring attributes from Software Diagnostics cluster

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
gen_config.h	Updated cluster command definition from SOFTWARE_DIAGNOSTICS ResetWatermarks to THREAD_NETWORK_DIAGNOSTICS ResetCounts
endpoint_config.h	Adjusted attribute counts and indices; removed Software Diagnostics heap attributes; added extensive Thread Network Diagnostics attributes (OverrunCount, role counters, TX/RX statistics); updated FeatureMap default value to 15; reassigned ResetCounts command
access.h	Corrected command privilege entries to associate ResetCounts with Thread Network Diagnostics (0x35) instead of Software Diagnostics (0x34)
IMClusterCommandHandler.cpp	Added dispatcher implementation for Thread Network Diagnostics ResetCounts command with proper TLV decoding and callback handling
closure.zap	Removed Software Diagnostics attributes and ResetWatermarks command; moved ResetCounts command to Thread Network Diagnostics; added all missing diagnostic attributes; changed FeatureMap default from "0" to "15"; corrected ActiveNetworkFaultsList defaultValue from "9" to null
closure.matter	Removed Software Diagnostics attributes and command handler; added 37 callback attributes to Thread Network Diagnostics; updated FeatureMap default to 15; added ResetCounts command handler

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[NordicBuilder]

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 2b68ce24b814079e51d26625c02680302c42ad49

more details

sdk-nrf:

PR head: 2b68ce24b814079e51d26625c02680302c42ad49
merge base: d6c88a74779647f151672a83b995215491d0df9a
target head (main): d6c88a74779647f151672a83b995215491d0df9a
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (6)

samples
│  ├── matter
│  │  ├── closure
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── closure.matter
│  │  │  │  │  ├── closure.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  ├── access.h
│  │  │  │  │  │  ├── endpoint_config.h
│  │  │  │  │  │  │ gen_config.h

Outputs:

Toolchain

Version: f911d4f4e7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f911d4f4e7_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

• ◻️ Toolchain - Skipped: existing toolchain is used
• ✅ Build twister
  • sdk-nrf test count: 11
• ✅ Integration tests
  • ✅ test-fw-nrfconnect-chip

Disabled integration tests

• • test-fw-nrfconnect-nrf_lrcs_mosh
  • desktop52_verification
  • test_ble_nrf_config
  • test-fw-nrfconnect-ble_mesh
  • test-fw-nrfconnect-ble_samples
  • test-fw-nrfconnect-fem
  • test-fw-nrfconnect-nfc
  • test-fw-nrfconnect-nrf-iot_cloud
  • test-fw-nrfconnect-nrf-iot_libmodem-nrf
  • test-fw-nrfconnect-nrf-iot_lwm2m
  • test-fw-nrfconnect-nrf-iot_samples
  • test-fw-nrfconnect-nrf-iot_thingy91
  • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
  • test-fw-nrfconnect-nrf_crypto
  • test-fw-nrfconnect-ps-main
  • test-fw-nrfconnect-rpc
  • test-fw-nrfconnect-rs
  • test-fw-nrfconnect-tfm
  • test-fw-nrfconnect-thread-main
  • test-low-level
  • test-sdk-audio
  • test-sdk-dfu
  • test-sdk-find-my
  • test-sdk-mcuboot
  • test-sdk-wifi
  • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI