-
Notifications
You must be signed in to change notification settings - Fork 1.4k
samples: cellular: modem_shell: Add support for DTLS frag extension #26451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for configuring the DTLS fragmentation extension in the modem shell sample's socket connect command. The new -F option allows users to specify DTLS fragmentation settings.
- Added
-F/--dtls_frag_extcommand-line option with values 0 (disabled), 1 (512 bytes), or 2 (1024 bytes) - Updated function signatures to pass the new parameter through the connection flow
- Implemented socket option setting for DTLS fragmentation extension
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| samples/cellular/modem_shell/src/sock/sock_shell.c | Added CLI option parsing and help text for DTLS fragmentation extension |
| samples/cellular/modem_shell/src/sock/sock.h | Updated function signature to include dtls_frag_ext parameter |
| samples/cellular/modem_shell/src/sock/sock.c | Implemented DTLS fragmentation extension socket option configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 72623a2ce34543913c9272ebf341663f144988cb more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: f911d4f4e7 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
2f8c53c to
f55a0cd
Compare
Added new command line option to the "socket connect" command for configuring the DTLS fragmentation extension. Signed-off-by: Tommi Kangas <[email protected]>
f55a0cd to
72623a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added new command line option to the "socket connect" command for configuring the DTLS fragmentation extension.