Skip to content

Conversation

@tokangas
Copy link
Contributor

@tokangas tokangas commented Jan 9, 2026

Added new command line option to the "socket connect" command for configuring the DTLS fragmentation extension.

@tokangas tokangas requested a review from a team as a code owner January 9, 2026 08:33
Copilot AI review requested due to automatic review settings January 9, 2026 08:33
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2026
@NordicBuilder NordicBuilder requested review from a team January 9, 2026 08:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring the DTLS fragmentation extension in the modem shell sample's socket connect command. The new -F option allows users to specify DTLS fragmentation settings.

  • Added -F/--dtls_frag_ext command-line option with values 0 (disabled), 1 (512 bytes), or 2 (1024 bytes)
  • Updated function signatures to pass the new parameter through the connection flow
  • Implemented socket option setting for DTLS fragmentation extension

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
samples/cellular/modem_shell/src/sock/sock_shell.c Added CLI option parsing and help text for DTLS fragmentation extension
samples/cellular/modem_shell/src/sock/sock.h Updated function signature to include dtls_frag_ext parameter
samples/cellular/modem_shell/src/sock/sock.c Implemented DTLS fragmentation extension socket option configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 9, 2026

CI Information

To view the history of this post, click the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 72623a2ce34543913c9272ebf341663f144988cb

more details

sdk-nrf:

PR head: 72623a2ce34543913c9272ebf341663f144988cb
merge base: 18ee80da084073dce0f905329288babbf089096d
target head (main): a61a7f641240ecccc8519af80b3e9d42d8f21f20
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
samples
│  ├── cellular
│  │  ├── modem_shell
│  │  │  ├── src
│  │  │  │  ├── sock
│  │  │  │  │  ├── sock.c
│  │  │  │  │  ├── sock.h
│  │  │  │  │  │ sock_shell.c

Outputs:

Toolchain

Version: f911d4f4e7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f911d4f4e7_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 84
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tokangas tokangas force-pushed the mosh_dtls_frag_ext branch from 2f8c53c to f55a0cd Compare January 9, 2026 08:47
Added new command line option to the "socket connect" command
for configuring the DTLS fragmentation extension.

Signed-off-by: Tommi Kangas <[email protected]>
Copilot AI review requested due to automatic review settings January 9, 2026 12:14
@tokangas tokangas force-pushed the mosh_dtls_frag_ext branch from f55a0cd to 72623a2 Compare January 9, 2026 12:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2026
@carlescufi carlescufi merged commit c1622d9 into nrfconnect:main Jan 9, 2026
19 checks passed
@tokangas tokangas deleted the mosh_dtls_frag_ext branch January 9, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants