-
Notifications
You must be signed in to change notification settings - Fork 347
nrf_modem: update library #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_modem: update library #1967
Conversation
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
59ebb52 to
ddde042
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
ddde042 to
4eeb32b
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
4eeb32b to
01bcc7c
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
01bcc7c to
558d46e
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
nrf_modem/Kconfig
Outdated
|
|
||
| config NRF_MODEM_LINK_BINARY_DECT_NRP | ||
| select EXPERIMENTAL | ||
| bool "DECT NR+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as said in Teams, I'd like to have a main flag for the DECT, and maybe also for the cellular.
I.e. to get rid of using CONFIG_NRF_MODEM_LIB as a synonym for LTE/cellular related code. See ncs usage for that and you'll see the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that the current use of CONFIG_NRF_MODEM_LIB in sdk-nrf is not ideal. However we will not do this now to avoid massively increasing the scope of this PR. It would be a nice improvement for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it is must to be solved somehow before these are going to some actual ncs release. Before this PR, this wasn't a problem in practice, as there were just cellular and dect_phy (that was not used for example in IP level or for cloud access).
558d46e to
7452e3a
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
7452e3a to
0f0fe25
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
fff2c22 to
d2ae6a7
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
d2ae6a7 to
188dbe4
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
188dbe4 to
adeb354
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
adeb354 to
0e7d155
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
0e7d155 to
349b6aa
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
b084b6b to
c70ac6e
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
c70ac6e to
9a5582d
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
nrf_modem/include/nrf_modem_dect.h
Outdated
| @@ -0,0 +1,2893 @@ | |||
| /* | |||
| * Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved. | |
| * Copyright (c) 2026 Nordic Semiconductor ASA. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was created in 2024, it has just been exported from somewhere else. Should I still update the year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong requirement, but I suggest we switch to (c) 2026 given that this file was never made public before
| * Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved. | ||
| * | ||
| * The information contained herein is confidential property of Nordic Semiconductor ASA. | ||
| * The use, copying, transfer or disclosure of such information is prohibited except by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this API doc be defined in the the API documentation - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrfxlib/nrf_modem/doc/api.html ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. This can be done in a later PR though, as we also need to update the variant overview, add the full docs and more.
nrf_modem/include/nrf_modem_dect.h
Outdated
| /** Radio device status, see @ref nrf_modem_dect_mac_rd_status for valid options. */ | ||
| uint16_t status; | ||
| /** | ||
| * If status is MEMORY_FULL, this field gives estimation for duration of situatio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * If status is MEMORY_FULL, this field gives estimation for duration of situatio. | |
| * If status is MEMORY_FULL, this field gives estimation for duration of situation. |
nrf_modem/include/nrf_modem_dect.h
Outdated
| } triggers; | ||
|
|
||
| /** | ||
| * IPv6 address configuration. If type is set other than NONE then IPv6 address is delivered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * IPv6 address configuration. If type is set other than NONE then IPv6 address is delivered | |
| * IPv6 address configuration. If type is set to other than NONE then IPv6 address is delivered |
9a5582d to
32cd9fb
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
32cd9fb to
5f09468
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
5f09468 to
16a48ab
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
SHA: 47715f47d3739a9e3a11f9635d4c2f9fc63126f7 Automatically created by libmodem Github workflow. Signed-off-by: Nordic Builder <[email protected]>
16a48ab to
390ede3
Compare
|
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1967 Signed-off-by: Nordic Builder <[email protected]>



Automatically created by libmodem Github workflow.