Skip to content

Conversation

@NordicBuilder
Copy link
Contributor

Automatically created by libmodem Github workflow.

@NordicBuilder NordicBuilder requested review from a team as code owners December 16, 2025 14:07
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 16, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from 59ebb52 to ddde042 Compare December 16, 2025 14:19
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 16, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from ddde042 to 4eeb32b Compare December 17, 2025 13:24
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 17, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from 4eeb32b to 01bcc7c Compare December 17, 2025 13:46
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 17, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from 01bcc7c to 558d46e Compare December 17, 2025 14:10
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 17, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>

config NRF_MODEM_LINK_BINARY_DECT_NRP
select EXPERIMENTAL
bool "DECT NR+"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as said in Teams, I'd like to have a main flag for the DECT, and maybe also for the cellular.
I.e. to get rid of using CONFIG_NRF_MODEM_LIB as a synonym for LTE/cellular related code. See ncs usage for that and you'll see the point.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree that the current use of CONFIG_NRF_MODEM_LIB in sdk-nrf is not ideal. However we will not do this now to avoid massively increasing the scope of this PR. It would be a nice improvement for the future.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is must to be solved somehow before these are going to some actual ncs release. Before this PR, this wasn't a problem in practice, as there were just cellular and dect_phy (that was not used for example in IP level or for cloud access).

@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from 558d46e to 7452e3a Compare December 18, 2025 12:49
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 18, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from 7452e3a to 0f0fe25 Compare December 18, 2025 12:52
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 18, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 18, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from fff2c22 to d2ae6a7 Compare December 18, 2025 13:03
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 18, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from d2ae6a7 to 188dbe4 Compare December 19, 2025 08:13
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 19, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from 188dbe4 to adeb354 Compare December 19, 2025 08:38
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 19, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from adeb354 to 0e7d155 Compare December 19, 2025 08:43
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 19, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from 0e7d155 to 349b6aa Compare December 19, 2025 15:22
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 19, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from b084b6b to c70ac6e Compare January 7, 2026 12:37
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jan 7, 2026
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 7, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from c70ac6e to 9a5582d Compare January 7, 2026 12:48
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 7, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@@ -0,0 +1,2893 @@
/*
* Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved.
Copy link
Contributor

@divipillai divipillai Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved.
* Copyright (c) 2026 Nordic Semiconductor ASA. All Rights Reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was created in 2024, it has just been exported from somewhere else. Should I still update the year?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong requirement, but I suggest we switch to (c) 2026 given that this file was never made public before

* Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved.
*
* The information contained herein is confidential property of Nordic Semiconductor ASA.
* The use, copying, transfer or disclosure of such information is prohibited except by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this API doc be defined in the the API documentation - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrfxlib/nrf_modem/doc/api.html ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. This can be done in a later PR though, as we also need to update the variant overview, add the full docs and more.

/** Radio device status, see @ref nrf_modem_dect_mac_rd_status for valid options. */
uint16_t status;
/**
* If status is MEMORY_FULL, this field gives estimation for duration of situatio.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If status is MEMORY_FULL, this field gives estimation for duration of situatio.
* If status is MEMORY_FULL, this field gives estimation for duration of situation.

} triggers;

/**
* IPv6 address configuration. If type is set other than NONE then IPv6 address is delivered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* IPv6 address configuration. If type is set other than NONE then IPv6 address is delivered
* IPv6 address configuration. If type is set to other than NONE then IPv6 address is delivered

@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from 9a5582d to 32cd9fb Compare January 7, 2026 15:36
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 7, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from 32cd9fb to 5f09468 Compare January 7, 2026 15:41
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 7, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordic-hani nordic-hani added the DNM Do not merge label Jan 8, 2026
@NordicBuilder NordicBuilder force-pushed the libmodem-auto-release-1020 branch from 5f09468 to 16a48ab Compare January 8, 2026 10:15
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 8, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
SHA: 47715f47d3739a9e3a11f9635d4c2f9fc63126f7

Automatically created by libmodem Github workflow.

Signed-off-by: Nordic Builder <[email protected]>
@nordic-mare nordic-mare force-pushed the libmodem-auto-release-1020 branch from 16a48ab to 390ede3 Compare January 8, 2026 11:04
@nordic-mare nordic-mare removed the DNM Do not merge label Jan 8, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 8, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
@nordicjm nordicjm merged commit ae711ee into nrfconnect:main Jan 8, 2026
7 of 8 checks passed
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 8, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
nordic-mare pushed a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 8, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
rlubos pushed a commit to nrfconnect/sdk-nrf that referenced this pull request Jan 8, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
travis3630 pushed a commit to travis3630/sdk-nrf that referenced this pull request Jan 9, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-nrfxlib#1967

Signed-off-by: Nordic Builder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants