[nrf noup] library: fix psa_destroy_key #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonZma
force-pushed
the
psa-storage-uid-size-fix
branch
from
5d58204 to
77af2da
Compare
AntonZma
changed the title
AntonZma
force-pushed
the
psa-storage-uid-size-fix
branch
from
77af2da to
514dc82
Compare
psa_destroy_persistent_key() improperly handled built-in keys. This resulted in ITS call attempted to delete the key that had never been created by it. Conditions for key creation and destruction are now aligned. This is a fixup for the following commit: [nrf noup] Allow import and destroy of builtin keys Signed-off-by: Anton Zyma <[email protected]>
AntonZma
force-pushed
the
psa-storage-uid-size-fix
branch
from
514dc82 to
6a9bd97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to destroy builtin key led to the
psa_destroy_persistent_key()call without callingpsa_save_persistent_key()prior to that.It may also be the reason for the ITS error related to the 30-bit limit of the
psa_key_id_tsize since psa_driver_wrapper may require 32-bit key ID.