[nrf toup] don't try to find volatile/builtin keys from wrong sources #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-font
force-pushed
the
fix_inexistant_volatile_key_handling
branch
from
85ad1f5 to
c31245a
Compare
tomi-font
changed the title
tomi-font
force-pushed
the
fix_inexistant_volatile_key_handling
branch
from
c31245a to
b3c148a
Compare
When not finding a given key in memory, the implementation would try to find it from the persistent keys regardless of the actual key type (volatile/builtin/persistent). Don't try to find inexistent volatile/builtin keys from persistent ones. In addition to the calls being superflous, the problem that was happening here is that the ITS implementation (Secure Storage subsystem) returns `PSA_ERROR_INVALID_ARGUMENT` because the ID is not in the persistent key range, and because it doesn't return `PSA_ERROR_DOES_NOT_EXIST` then the wrong error code is propagated back to the caller. `toup` as the issue has been communicated to Mbed TLS and should be fixed there. See: - Mbed-TLS/TF-PSA-Crypto#488 - Mbed-TLS/TF-PSA-Crypto#492 Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
force-pushed
the
fix_inexistant_volatile_key_handling
branch
from
b3c148a to
7873339
Compare
degjorva
approved these changes
Oct 2, 2025
PFnord
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not finding a given key in memory, the implementation would try to find it from the persistent keys regardless of the actual key type (volatile/builtin/persistent).
Don't try to find inexistent volatile/builtin keys from persistent ones.
In addition to the calls being superflous, the problem that was happening here is that the ITS implementation (Secure Storage subsystem) returns
PSA_ERROR_INVALID_ARGUMENTbecause the ID is not in the persistent key range, and because it doesn't returnPSA_ERROR_DOES_NOT_EXISTthen the wrong error code is propagated back to the caller.toupas the issue has been communicated to Mbed TLS and should be fixed there.See: