[nrf noup] platform: nordic_nrf: Fix bug in nrfx errata #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrfx have some functions which dynamically checks if an errata should be applied based on a value in FICR. It seems that reading two values from FICR consecutively has undefined behavior if each call is not followed by a __DSB call. This commit fixes the issue by copying the nrfx header with the errata functions and adding a __DSB call to each FICR read. This is a (hopefully) short lived noup since the fix will come in nrfx. Ref: NCSDK-36641 Signed-off-by: Georgios Vasilakis <[email protected]>
Vge0rge
force-pushed
the
nrf91_errata_fix
branch
from
9a55d91 to
b25a363
Compare
tomi-font
reviewed
Dec 8, 2025
Collaborator
tomi-font
left a comment
tomi-font
left a comment
There was a problem hiding this comment.
Could we instead just fix this directly in nrfx and pull in an updated version? How critical is it to have the fix beforehand here?
Contributor
Author
Fixing in nrfx is not in our (team) control, right now this is broken in main so I think that it makes sense to fix it here until nrfx is ready. |
tomi-font
approved these changes
Dec 8, 2025
Contributor
Author
|
Ping, if you guys @nika-nordic @masz-nordic guys can have a look it will be great 👍 |
Collaborator
|
ping @nika-nordic @masz-nordic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrfx have some functions which dynamically checks if an errata should be applied based on a value in FICR. It seems that reading two values from FICR consecutively has undefined behavior if each call is not followed by a __DSB call.
This commit fixes the issue by copying the nrfx header with the errata functions and adding a __DSB call to each FICR read.
This is a (hopefully) short lived noup since the fix will come in nrfx.