Update soc nordic test spec #3672
Conversation
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3672 Signed-off-by: Nordic Builder <[email protected]>
| - any: | ||
| - "soc/nordic/**/*" | ||
| - "!soc/nordic/nrf51*" | ||
| - "!soc/nordic/nrf52*" |
There was a problem hiding this comment.
why we want to remove validating nrf52 series?
There was a problem hiding this comment.
Looking at execution of downstream, only L15 and LM20 are tested, none of nrf52, thus there is no point to trigger it for such changes.
There was a problem hiding this comment.
Is there a task stating to remove all 51 52 53 and 91 validation? If there is no, please create a task in Jira. We need a clear requirement before they are removed.
There was a problem hiding this comment.
Looking at execution of downstream, only L15 and LM20 are tested, none of nrf52, thus there is no point to trigger it for such changes.
It was mentioned to stop testing 52 from next LTS, but we should keep 52 testing for some relative time. Do you want to remove 52 now or when it is supposed to be stopped with testing.
Also is 53 supposed to be removed as well?
There was a problem hiding this comment.
No, I am just looking at boards which are actually used by integration CI - I remove those not used by specific downstream.
There was a problem hiding this comment.
@guwa It is just integration scope, not affecting testing in general.
Already talked with @rugeGerritsen, will keep nrf52 and nrf53.
ppryga-nordic
requested review from
guwa
and removed request for
ppryga-nordic
rugeGerritsen
left a comment
rugeGerritsen
left a comment
There was a problem hiding this comment.
Two changes needed:
- For Bluetooth tests we should not remove triggering CI on these platforms.
- The commit message needs to contain a reason for why testing is disabled.
nrf-squash! [nrf noup] ci: add .github/test-spec.yml More granular at soc. Signed-off-by: Piotr Kosycarz <[email protected]>
nrf-squash! [nrf noup] ci: add .github/test-spec.yml More granular at soc. Signed-off-by: Piotr Kosycarz <[email protected]>
nrf-squash! [nrf noup] ci: add .github/test-spec.yml More granular at soc. Signed-off-by: Piotr Kosycarz <[email protected]>
nrf-squash! [nrf noup] ci: add .github/test-spec.yml More granular at soc. Signed-off-by: Piotr Kosycarz <[email protected]>
nordic-piks
force-pushed
the
update_soc_nordic_test_spec
branch
from
d19a9fd to
687777a
Compare
Updated. |
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3672 Signed-off-by: Nordic Builder <[email protected]>
Would you mind updating the commit message to state: test-ble is not validating nrf51 and nrf91, so it does not make sense to trigger ci on these changes |
nrf-squash! [nrf noup] ci: add .github/test-spec.yml More granular at soc. test-ble is not validating nrf51 and nrf91, so it does not make sense to trigger ci on these changes. Signed-off-by: Piotr Kosycarz <[email protected]>
nordic-piks
force-pushed
the
update_soc_nordic_test_spec
branch
from
687777a to
61c8d42
Compare
Done, thanks :) |
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3672 Signed-off-by: Nordic Builder <[email protected]>
rugeGerritsen
left a comment
rugeGerritsen
left a comment
There was a problem hiding this comment.
Reviewed Bluetooth testing
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3672 Signed-off-by: Nordic Builder <[email protected]>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3672 Signed-off-by: Nordic Builder <[email protected]>
8 participants
No description provided.