Skip to content

Commit

Permalink
chore: update ci to use node18. dont fail if codecov send fails
Browse files Browse the repository at this point in the history
  • Loading branch information
Julusian committed Sep 25, 2023
1 parent 496d3e3 commit 5c6d342
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 15 deletions.
23 changes: 10 additions & 13 deletions .github/workflows/node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Use Node.js 14.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
- name: Prepare Environment
run: |
yarn install
Expand Down Expand Up @@ -61,12 +61,9 @@ jobs:
CI: true
- name: Send coverage
uses: codecov/codecov-action@v3
if: matrix.node-version == '14.x'
with:
fail_ci_if_error: true
# name: codecov-umbrella
if: matrix.node-version == '18.x'
- name: Check docs generation
if: matrix.node-version == '14.x'
if: matrix.node-version == '18.x'
run: |
yarn docs:test
env:
Expand All @@ -88,10 +85,10 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Use Node.js 14.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
- name: Check release is desired
id: do-publish
run: |
Expand Down Expand Up @@ -155,10 +152,10 @@ jobs:

# steps:
# - uses: actions/checkout@v4
# - name: Use Node.js 14.x
# - name: Use Node.js 18.x
# uses: actions/setup-node@v3
# with:
# node-version: 14.x
# node-version: 18.x
# - name: Prepare Environment
# run: |
# yarn install
Expand All @@ -182,10 +179,10 @@ jobs:

# steps:
# - uses: actions/checkout@v4
# - name: Use Node.js 14.x
# - name: Use Node.js 18.x
# uses: actions/setup-node@v3
# with:
# node-version: 14.x
# node-version: 18.x
# - name: Prepare Environment
# run: |
# yarn install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Use Node.js 14.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
- name: Check release is desired
id: do-publish
run: |
Expand Down

0 comments on commit 5c6d342

Please sign in to comment.